Federico Simoncelli has posted comments on this change.
Change subject: vm: add the live diskSizeExtend method
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File client/vdsClient.py
Line 1696: 'volumeID': volUUID
Line 1697: }, newSize)
Line 1698:
Line 1699: if status['status']['code'] == 0:
Line 1700: print "New disk size: " + status.get('size', 0)
Done
Line 1701:
Line 1702: return status['status']['code'], status['status']['message']
Line 1703:
Line 1704: if __name__ == '__main__':
Line 2432: )),
Line 2433: 'diskSizeExtend': (
Line 2434: serv.diskSizeExtend, (
Line 2435: '<vmId> <spUUID> <sdUUID> <imgUUID> <volUUID>
<newSize>',
Line 2436: 'Finish live replication to the destination domain'
Done
Line 2437: )),
Line 2438: }
Line 2439: if _glusterEnabled:
Line 2440: commands.update(ge.getGlusterCmdDict(serv))
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5873: #
Line 5874: # Since: 4.12.0
Line 5875: ##
Line 5876: {'command': {'class': 'VM', 'name': 'diskSizeExtend'},
Line 5877: 'data': {'vmID': 'UUID', 'driveSpecs': 'DriveSpecVolume',
'newSize': 'str'},
str as int cannot represent integers large enough (in xmlrpc), check also other
storage API.
Line 5878: 'returns': 'str'}
Line 5879:
Line 5880: ## Category: @Volume
###########################################################
Line 5881: ##
....................................................
File vdsm/vm.py
Line 3779:
Line 3780: drive = self._findDriveByUUIDs(driveSpecs)
Line 3781:
Line 3782: try:
Line 3783: diskFormat = "qcow2" if drive.format == "cow" else "raw"
Done
Line 3784: # Apparently this is what libvirt would do anyway,
except that
Line 3785: # it would fail on NFS when root_squash is enabled, see
BZ#963881
Line 3786: currentSize = qemuImg.info(drive.path,
diskFormat)['virtualsize']
Line 3787:
--
To view, visit http://gerrit.ovirt.org/15614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
