Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: report migration status in getVMList() call ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vm.py Line 149: if t is not None: Line 150: # fetch migration status from the monitor thread Line 151: self.status['progress'] = int( Line 152: float(t.data_progress + t.mem_progress) / 2) Line 153: self.status['total'] = t.total It looks to me like t.total always stays 0 Line 154: self.status['remaining'] = t.remaining Line 155: self.status['lowmark'] = t.remaining_lowmark Line 156: elif optional: Line 157: return None -- To view, visit http://gerrit.ovirt.org/15125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc32fa00eaa1b90c3ba9d0afffdeb1cdd8150f9a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
