Peter V. Saveliev has posted comments on this change. Change subject: vdsm: report migration status in getVMList() call ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 7: vdsm: report migration status in getVMList() call Line 8: Line 9: getVMList() is polled by the engine every 3 sec, so it is not the worst place Line 10: for migration statistics — if VM is in the migration state. Thus, the engine Line 11: will be able to track migration progress without explicit call 'Cause we poll getVmStats. By the matter of fact, it is a poll point. We can use another one. It will double traffic with extra XML-RPC, is it OK? If OK, I will remove migrateStatus() from getVmList() and we will use a separated verb. I have nothing against this approach, just we need the feature. Line 12: migrationStatus() for each VM. Line 13: Line 14: Signed-off-by: Peter V. Saveliev <p...@redhat.com> -- To view, visit http://gerrit.ovirt.org/15125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc32fa00eaa1b90c3ba9d0afffdeb1cdd8150f9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
