Michal Skrivanek has posted comments on this change. Change subject: vdsm: report migration status in getVMList() call ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 7: vdsm: report migration status in getVMList() call Line 8: Line 9: getVMList() is polled by the engine every 3 sec, so it is not the worst place Line 10: for migration statistics — if VM is in the migration state. Thus, the engine Line 11: will be able to track migration progress without explicit call the main motivation is to reduce the bandwidth and the number of requests we issue from the engine. This way we do not require new threads on engine to poll specifically just for progress. We already have a poll request which is going out frequently. I don't think API-wise it's that bad, surely it's not very nice either - but the overall benefit of reducing the load and code complexity and network bandwidth outweighs that "disadvantage" Line 12: migrationStatus() for each VM. Line 13: Line 14: Signed-off-by: Peter V. Saveliev <[email protected]> -- To view, visit http://gerrit.ovirt.org/15125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc32fa00eaa1b90c3ba9d0afffdeb1cdd8150f9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
