Bala.FA has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script ......................................................................
Patch Set 11: (2 inline comments) .................................................... File lib/vdsm/tool/libvirt_configure.py Line 77: 3. libvirtd Line 78: 4. qemu-sanlock.conf Line 79: For using default files, don't pass parameters. Line 80: """ Line 81: raise RuntimeError(usageMsg) This case, userMsg won't be written to stdout. Is it expected? Line 82: Line 83: sys.stdout.write(usageMsg) Line 84: Line 85: .................................................... File lib/vdsm/tool/libvirt_configure.sh.in Line 38: qconf="$2" Line 39: Line 40: ssl=`"$GETCONFITEM" "$VDSM_CONF_FILE" vars ssl true | tr A-Z a-z` Line 41: if [ "$ssl" = '' ]; then Line 42: echo 'FAILED: Could not read configuration' 1>&2 Is it good idea to change the text something like 'FAILED: Could not read configuration: ssl' Line 43: return 3 Line 44: fi Line 45: Line 46: if [ "$ssl" = "true" ]; then -- To view, visit http://gerrit.ovirt.org/15216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
