Giuseppe Vallarelli has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script ......................................................................
Patch Set 11: I would prefer that you didn't submit this (2 inline comments) Minor comments. .................................................... File lib/vdsm/tool/libvirt_configure.py Line 16: # Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: from vdsm import utils Hi Yaniv you should change the import statements, first stdlib than proj.lib for more information have a look to http://www.python.org/dev/peps/pep-0008/#imports Line 21: import vdsm.tool Line 22: import os Line 23: import sys Line 24: .................................................... File lib/vdsm/tool/Makefile.am Line 37: dist_vdsmtool_DATA = \ Line 38: __init__.py \ Line 39: dummybr.py \ Line 40: nwfilter.py \ Line 41: libvirt_configure.py \ Perhaps you should place this one before nwfilter to respect the predefined order. Same for libvirt_configure in EXTRA_DIST. Line 42: passwd.py \ Line 43: seboolsetup.py \ Line 44: service.py \ Line 45: vdsm-id.py \ -- To view, visit http://gerrit.ovirt.org/15216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
