Zhou Zheng Sheng has posted comments on this change.

Change subject: Extend vdsm-tool: moving configure libvirt to external shell 
script
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 258: 
Line 259:     local llogr=/etc/logrotate.d/libvirtd
Line 260:     local stanza=`mktemp`
Line 261:     /bin/cat > "$stanza" <<EOF
Line 262: # vdsm
I think you can update this line as well, it should be

/var/log/libvirt/libvirtd.log {

See git show fe01963f for a reference.
Line 263: /var/log/libvirtd.log {
Line 264:     rotate 100
Line 265:     missingok
Line 266:     copytruncate


-- 
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to