Zhou Zheng Sheng has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
......................................................................
Patch Set 14: I would prefer that you didn't submit this
(1 inline comment)
I'm afraid I find another small problem while testing the patch.
....................................................
File vdsm/vdsmd.init.in
Line 77: /sbin/restorecon "$run_path"
Line 78: done
Line 79: }
Line 80:
Line 81: get_libvirt_conf_item() {
This function is used in libvirt_configure.sh.in, but not in vdsmd.init.in, so
get_libvirt_conf_item should be moved to libvirt_configure.sh.in as well.
Line 82: local cfile
Line 83: local key
Line 84:
Line 85: cfile=$1
--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
