Dan Kenigsberg has posted comments on this change.

Change subject: Decoupling libvirtconnection.py from clintIf.py
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File lib/vdsm/libvirtconnection.py
Line 92:                     log.error('connection to libvirt broken. ')
Line 93:                     if killOnFailure:
Line 94:                         log.error('taking calling process down. ecode:'
Line 95:                                   ' %d edom: %d', ecode, edom)
Line 96:                         os.kill(os.getpid(), 15)
ah, ok. I've mis-parsed Mooli's English.
Line 97:                 else:
Line 98:                     log.debug('Unknown libvirterror: ecode: %d edom: 
%d '
Line 99:                               'level: %d message: %s', ecode, edom,
Line 100:                               e.get_error_level(), 
e.get_error_message())


-- 
To view, visit http://gerrit.ovirt.org/16393
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to