mooli tayer has posted comments on this change. Change subject: Decoupling libvirtconnection.py from clintIf.py ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 14: causes vdsm to shutdown on libvirt connection error) Line 15: Line 16: These two come in the same patch because removing Line 17: the cli dependency (clientIF instance) from libvirtconnection Line 18: must handle errors in a new way - sendind SIGTERM to the current This is why I could not separate the patches: If I do as you suggested one patch where I only do os.kill instead of cif.prepareForShutdown the bug would not be fixed - only libvirtconnection.get calls done with cif used to go through wrapMethod. to make all calls go through wrapMethod I had to also Decoupling libvirtconnection.py from clintIf.py as part of the bug fix Line 19: process which solves the bug. Line 20: Line 21: Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Line 22: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958367 -- To view, visit http://gerrit.ovirt.org/16393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
