Dan Kenigsberg has posted comments on this change. Change subject: Decoupling libvirtconnection.py from clintIf.py ......................................................................
Patch Set 2: I would prefer that you didn't submit this (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-07-01 15:33:37 +0300 Line 4: Commit: Mooli Tayer <[email protected]> Line 5: CommitDate: 2013-07-08 12:48:15 +0300 Line 6: Line 7: Decoupling libvirtconnection.py from clintIf.py clintIf -> clientIF Line 8: Line 9: 1.) Decoupling libvirtconnection.py from clientIF.py Line 10: adding libvirt cb handlers for vm events belongs in vm.py Line 11: 2.) bugfix: not all libviryconnecition.get() invocations Line 14: causes vdsm to shutdown on libvirt connection error) Line 15: Line 16: These two come in the same patch because removing Line 17: the cif dependency (clientIF instance) from libvirtconnection Line 18: must handle errors in a new way - sendind SIGTERM to the current did you intentionally ignore my request to put this into a preceding patch? sendind -> sending? Line 19: process which solves the bug. Line 20: Line 21: Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Line 22: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958367 .................................................... File lib/vdsm/libvirtconnection.py Line 63: Line 64: def get(target=None, killOnFailure=True): Line 65: """Return current connection to libvirt or open a new one. Line 66: Use target to get/create the connection object linked to that object. Line 67: If target has a callable attribute named 'dispatchLibvirtEvents' it why are we making this a conditional? the target *has* to have this callable. Why do we need the added complexity, and runtime hasattr() calls? Line 68: will be registered as a callback on libvirt events. Line 69: Line 70: Wrap methods of connection object so that they catch disconnection, and Line 71: take the current process down. -- To view, visit http://gerrit.ovirt.org/16393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
