Alon Bar-Lev has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
......................................................................
Patch Set 15: (2 inline comments)
....................................................
File vdsm/vdsmd.init.in
Line 32: CORE_PATTERN=/proc/sys/kernel/core_pattern
Line 33: NEEDED_SERVICES="iscsid multipathd ntpd wdmd sanlock network libvirtd
Line 34: supervdsmd"
Line 35: CONFLICTING_SERVICES="libvirt-guests"
Line 36: VDSM_TOOL=@BINDIR@/vdsm-tool
I would have separated the introduction of VDSM_TOOL into this file as it
touches more than libvirt configuration code. and it is quick merge.
Line 37:
Line 38: is_coredump=`$GETCONFITEM $CONF_FILE vars core_dump_enable false | tr
A-Z a-z`
Line 39: [ "$is_coredump" != "true" ] && is_coredump=false
Line 40:
Line 164: RETVAL=0
Line 165:
Line 166: reconfigure_libvirt() {
Line 167: if [ "$1" = "force" ]; then
Line 168: "$VDSM_TOOL" force-reconfigure
can't we have:
vdsm-tool libvirt-configure
vdsm-tool libvirt-configure --force
?
Line 169: else
Line 170: "$VDSM_TOOL" configure-libvirt
Line 171: fi
Line 172: }
--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
