Federico Simoncelli has posted comments on this change.

Change subject: vm: add the live diskSizeExtend method
......................................................................


Patch Set 8: Verified

(1 inline comment)

Minor changes (comments, etc.). Reinstating Verified.

....................................................
File vdsm/storage/hsm.py
Line 659:         newSizeSectors = (newSizeBytes + SECTOR_SIZE - 1) / 
SECTOR_SIZE
Line 660:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 661:         self._spmSchedule(
Line 662:             spUUID, "extendVolumeSize", pool.extendVolumeSize, sdUUID,
Line 663:             imgUUID, volUUID, newSizeSectors)
This doesn't strictly belong to this patch but we might want to get it anyway. 
(See comments on previous patch set).
Line 664: 
Line 665:     @public
Line 666:     def updateVolumeSize(self, spUUID, sdUUID, imgUUID, volUUID, 
newSize):
Line 667:         """


-- 
To view, visit http://gerrit.ovirt.org/15614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to