Ayal Baron has posted comments on this change.
Change subject: vm: add the live diskSizeExtend method
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 659: newSizeBlocks = (newSizeBytes + SECTOR_SIZE - 1) / SECTOR_SIZE
Line 660: vars.task.getSharedLock(STORAGE, sdUUID)
Line 661: self._spmSchedule(
Line 662: spUUID, "extendVolumeSize", pool.extendVolumeSize, sdUUID,
Line 663: imgUUID, volUUID, newSizeBlocks)
s/Blocks/Sectors/ ?
Line 664:
Line 665: @public
Line 666: def updateVolumeSize(self, spUUID, sdUUID, imgUUID, volUUID,
newSize):
Line 667: """
Line 675: volToExtend = domain.produceVolume(imgUUID, volUUID)
Line 676: volPath = volToExtend.getVolumePath()
Line 677: volFormat = volToExtend.getFormat()
Line 678:
Line 679: if not volToExtend.isLeaf(): # not leaf and not shared
comment is incorrect ('not shared')
I'd just drop it.
Line 680: raise se.VolumeNonWritable(self.volUUID)
Line 681:
Line 682: if volFormat != volume.COW_FORMAT:
Line 683: # This method is used only with COW volumes (see
docstring),
--
To view, visit http://gerrit.ovirt.org/15614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
