Federico Simoncelli has posted comments on this change. Change subject: vm: add the live diskSizeExtend method ......................................................................
Patch Set 7: (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 702: qemuImgFormat)['virtualsize'] Line 703: finally: Line 704: volToExtend.teardown(sdUUID, volUUID) Line 705: Line 706: # Rounding down as qemu/qemu-img offline discussion: rounding up. Line 707: volToExtend.setSize(roundedSizeBytes / SECTOR_SIZE) Line 708: return dict(size=str(roundedSizeBytes)) Line 709: Line 710: @public .................................................... File vdsm/storage/volume.py Line 713: def setSize(self, size): Line 714: self.setMetaParam(SIZE, size) Line 715: Line 716: def updateInvalidatedSize(self): Line 717: # During some complex flows the volume size might have been maked as Marked Line 718: # invalidated (e.g. during a transaction). Here we are checking Line 719: # NOTE: the prerequisite to run this is that the volume is accessible Line 720: # (e.g. lv active) and not in use by another process (e.g. dd, qemu). Line 721: # Going directly to the metadata parameter as we should skip the size -- To view, visit http://gerrit.ovirt.org/15614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
