Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Add dhcp support for iproute2 configurator ......................................................................
Patch Set 4: (1 comment) .................................................... File vdsm/netconf/iproute2.py Line 205: def shutdown(self): Line 206: try: Line 207: pid = int(open(self.pidFile).readline().strip()) Line 208: except IOError as e: Line 209: if e.errno == os.errno.ENOENT: I was playing with something in the lines of http://bugs.python.org/issue15806 and seeing this message I decided to push it as: http://gerrit.ovirt.org/#/c/17661/ I know that it is not very conventional, but IMHO it is much more readable than the status quo, and the fact that the python devs are looking for something similar is reassuring. Line 210: pass Line 211: else: Line 212: raise Line 213: else: -- To view, visit http://gerrit.ovirt.org/15492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
