Mark Wu has posted comments on this change. Change subject: netconf: Add dhcp support for iproute2 configurator ......................................................................
Patch Set 4: (1 comment) .................................................... File vdsm/netconf/iproute2.py Line 250: def ifup(self, iface): Line 251: ipwrapper.linkSet(['dev', iface.name, 'up']) Line 252: _, _, _, bootproto, async = iface.getIpConfig() Line 253: if bootproto == 'dhcp': Line 254: dhclient = DhcpClient(iface.name) thanks for the explanation. ifup only needs DhcpClient if the bootproto is 'dhcp', I don't want to expose these details to configurator level. So for this case, it seems not suitable to make the dependency explicit. And MonkeyPatch should work fine with it. If you have any thoughts about the potential test problem with this code, please let me know. Thanks. Line 255: dhclient.start(async) Line 256: Line 257: def ifdown(self, iface): Line 258: ipwrapper.linkSet(['dev', iface.name, 'down']) -- To view, visit http://gerrit.ovirt.org/15492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
