Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/netconf/iproute2.py
Line 172: if rc:
Line 173: logging.error('Restore network configuration failed: %s',
err)
Line 174:
Line 175:
Line 176: class DhcpClient():
I think it could make sense to have this class in it's own module just like
ipwrapper is.
Line 177: PID_FILE = '/var/run/dhclient-%s.pid'
Line 178: LEASE_DIR = '/var/lib/dhclient/'
Line 179: LEASE_FILE = LEASE_DIR + 'dhclient-%s.lease'
Line 180: DHCLIENT = CommandPath('dhclient', '/sbin/dhclient')
--
To view, visit http://gerrit.ovirt.org/15492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
