Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
......................................................................
Patch Set 5: Code-Review-1
(3 comments)
....................................................
File lib/vdsm/dhclient.py
Line 1: # Copyright 2013 Red Hat, Inc.
Mark, shouldn't this be IBM?
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or
Line 25: from vdsm.utils import execCmd
Line 26: from vdsm.utils import rmFile
Line 27:
Line 28:
Line 29: class DhcpClient():
It should inherit from object to be a new-style class.
Line 30: PID_FILE = '/var/run/dhclient-%s.pid'
Line 31: LEASE_DIR = '/var/lib/dhclient/'
Line 32: LEASE_FILE = LEASE_DIR + 'dhclient-%s.lease'
Line 33: DHCLIENT = CommandPath('dhclient', '/sbin/dhclient')
Line 35: def __init__(self, iface):
Line 36: self.iface = iface
Line 37: self.pidFile = self.PID_FILE % self.iface
Line 38: if not os.path.exists(self.LEASE_DIR):
Line 39: execCmd(['mkdir', self.LEASE_DIR])
this should be os.mkdir
Line 40: self.leaseFile = (self.LEASE_FILE % self.iface)
Line 41:
Line 42: def _dhclient(self):
Line 43: rc, out, err = execCmd([self.DHCLIENT.cmd, '-1', '-pf',
--
To view, visit http://gerrit.ovirt.org/15492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
