Francesco Romani has posted comments on this change.

Change subject: vm: floppy: remove special 'readonly' handling
......................................................................


Patch Set 1:

This patch only deletes code.
This check is additional with respect to the information sent by engine (VDSM 
can add on its own the 'readonly' flag).

Given the fact we have reports of this code doing more harm than good (VM stuck 
in 'wait for lunch' because of the domain not accessible)
and given the fact make check passes cleanly, I ticked 'Verified'.

Please let me know if this reasoning is wrong, and, if so, which verification 
is needed.

-- 
To view, visit http://gerrit.ovirt.org/26937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9183104d3739f2d4a99712e7851fc3172b82621
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to