Francesco Romani has posted comments on this change.

Change subject: vm: floppy: remove special 'readonly' handling
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26937/2//COMMIT_MSG
Commit Message:

Line 19: started.
Line 20: 
Line 21: To address those issues, this patch removes the
Line 22: explicit additional check and all the code which was
Line 23: used only by it.
> I'm very pleased to see this code go away, but there is a possibility for t
Just a wild idea but... IIUC floppy nowadays are used just for sysprep and/or 
to fed installer with (virtio) drivers.
If so, maybe we can just mark them always read-only, because on such scenarios 
the guest will just read from them
Line 24: 
Line 25: Change-Id: Ie9183104d3739f2d4a99712e7851fc3172b82621
Line 26: Bug-Url: https://bugzilla.redhat.com/755528


-- 
To view, visit http://gerrit.ovirt.org/26937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9183104d3739f2d4a99712e7851fc3172b82621
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to