Francesco Romani has posted comments on this change. Change subject: vm: return diskMapping on status() ......................................................................
Patch Set 2: (3 comments) a few comments about the schema http://gerrit.ovirt.org/#/c/31700/2/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3554: # Line 3555: # @guestIPs: A space separated string of assigned IPv4 addresses Line 3556: # Line 3557: # @guestDiskMapping: A dictionary containing information about the disk mapping Line 3558: # within the guest. The key is the first 20 characters of the I find this restriction of the first 20 characters surprising. Why it is so? Line 3559: # disk id and the value is the mapping information. Line 3560: # Line 3561: # @smartcardEnable: Info whether smartcard is enabled. Line 3562: # Line 3556: # Line 3557: # @guestDiskMapping: A dictionary containing information about the disk mapping Line 3558: # within the guest. The key is the first 20 characters of the Line 3559: # disk id and the value is the mapping information. Line 3560: # please add the (new in version 4.1X.Y) note Line 3561: # @smartcardEnable: Info whether smartcard is enabled. Line 3562: # Line 3563: # @nicModel: The type of device that is exposed to the VM operating system Line 3564: # Line 3583: ': please elaborate the type, maybe StringMap is probably more correct (but I don't really know :) ) -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
