Liron Aravot has posted comments on this change. Change subject: vm: return diskMapping on status() ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/31700/2/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3554: # Line 3555: # @guestIPs: A space separated string of assigned IPv4 addresses Line 3556: # Line 3557: # @guestDiskMapping: A dictionary containing information about the disk mapping Line 3558: # within the guest. The key is the first 20 characters of the > I find this restriction of the first 20 characters surprising. Why it is so it's because the serial of the disk within the guest is 20 characters, but i'll change it to a better description Line 3559: # disk id and the value is the mapping information. Line 3560: # Line 3561: # @smartcardEnable: Info whether smartcard is enabled. Line 3562: # Line 3556: # Line 3557: # @guestDiskMapping: A dictionary containing information about the disk mapping Line 3558: # within the guest. The key is the first 20 characters of the Line 3559: # disk id and the value is the mapping information. Line 3560: # > please add the Added that on the type, I'm not sure that it's needed somewhere else from what i've seen in that file. Line 3561: # @smartcardEnable: Info whether smartcard is enabled. Line 3562: # Line 3563: # @nicModel: The type of device that is exposed to the VM operating system Line 3564: # Line 3579: 'displaySecurePort': 'uint', 'spiceSecureChannels': 'str', Line 3580: 'username': 'str', 'emulatedMachine': 'str', 'pid': 'uint', Line 3581: 'spiceSslCipherSuite': 'str', 'cpuType': 'str', 'pauseCode': 'str', Line 3582: 'guestFQDN': 'str', 'displayIp': 'str', 'keyboardLayout': 'str', Line 3583: 'displayPort': 'uint', 'guestIPs': 'str', 'guestDiskMapping': 'str', > This should be probably a new type - see how custom types are defined elsew Done Line 3584: 'smartcardEnable': 'bool', 'nicModel': 'VmInterfaceDeviceModel', Line 3585: 'pitReinjection': 'bool', 'status': 'str', 'clientIp': 'str'}} Line 3586: Line 3587: ## -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
