Nir Soffer has posted comments on this change. Change subject: vm: return diskMapping on status() ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31700/2/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3579: 'displaySecurePort': 'uint', 'spiceSecureChannels': 'str', Line 3580: 'username': 'str', 'emulatedMachine': 'str', 'pid': 'uint', Line 3581: 'spiceSslCipherSuite': 'str', 'cpuType': 'str', 'pauseCode': 'str', Line 3582: 'guestFQDN': 'str', 'displayIp': 'str', 'keyboardLayout': 'str', Line 3583: 'displayPort': 'uint', 'guestIPs': 'str', 'guestDiskMapping': 'str', > please elaborate the type, maybe StringMap is probably more correct (but I This should be probably a new type - see how custom types are defined elsewhere in this file. Line 3584: 'smartcardEnable': 'bool', 'nicModel': 'VmInterfaceDeviceModel', Line 3585: 'pitReinjection': 'bool', 'status': 'str', 'clientIp': 'str'}} Line 3586: Line 3587: ## -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
