Francesco Romani has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 19: Code-Review-1 (4 comments) good direction, only minor comments about improvements. -1 for visibility. http://gerrit.ovirt.org/#/c/33309/19/tests/v2vTests.py File tests/v2vTests.py: Line 24: from testlib import VdsmTestCase as TestCaseBase Line 25: from monkeypatch import MonkeyPatch Line 26: Line 27: Line 28: class VmMock(object): I'd rather extend/use vmfakeslib Line 29: def name(self): Line 30: return 'windows' Line 31: Line 32: def state(self, flags=0): Line 65: </devices> Line 66: </domain>""" Line 67: Line 68: Line 69: class LibvirtMock(object): same Line 70: def close(self): Line 71: pass Line 72: Line 73: def listAllDomains(self): http://gerrit.ovirt.org/#/c/33309/19/vdsm/virt/vmstatus.py File vdsm/virt/vmstatus.py: Line 34: Line 35: UNKNOWN = 'Unknown' Line 36: BLOCKED = 'Blocked' Line 37: CRASHED = 'Crashed' Line 38: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended' please merge this new group with the existing one, and make it sorted alphabetically Line 39: Line 40: statusMsg = {libvirt.VIR_DOMAIN_NOSTATE: UNKNOWN, Line 41: libvirt.VIR_DOMAIN_RUNNING: UP, Line 42: libvirt.VIR_DOMAIN_BLOCKED: BLOCKED, Line 36: BLOCKED = 'Blocked' Line 37: CRASHED = 'Crashed' Line 38: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended' Line 39: Line 40: statusMsg = {libvirt.VIR_DOMAIN_NOSTATE: UNKNOWN, I'd rather use 'statuses', following the line of 'vmexitreason.py'. It should not clash with other names Line 41: libvirt.VIR_DOMAIN_RUNNING: UP, Line 42: libvirt.VIR_DOMAIN_BLOCKED: BLOCKED, Line 43: libvirt.VIR_DOMAIN_PAUSED: PAUSED, Line 44: libvirt.VIR_DOMAIN_SHUTDOWN: POWERING_DOWN, -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
