Shahar Havivi has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36263/2/vdsm/v2v.py File vdsm/v2v.py: Line 121: try: Line 122: vol = conn.storageVolLookupByPath(source.get('file')) Line 123: d['truesize'] = str(vol.info()[1]) Line 124: except libvirt.libvirtError: Line 125: pass > You cannot ignore errors like this. You must at least log the error instanc :) Line 126: params['disks'].append(d) Line 127: Line 128: Line 129: def _add_networks(root, params): -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
