Francesco Romani has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 4: Code-Review-1 (1 comment) possible error (typo?) into log message, otherwise looks good. http://gerrit.ovirt.org/#/c/36263/4/vdsm/v2v.py File vdsm/v2v.py: Line 123: vol = conn.storageVolLookupByPath(source.get('file')) Line 124: d['truesize'] = str(vol.info()[1]) Line 125: except libvirt.libvirtError as e: Line 126: logging.error('error parsing storage size, msg: %s xml: %s', Line 127: e.message) I see two '%s' in the format string, but just one more argument. Line 128: params['disks'].append(d) Line 129: Line 130: Line 131: def _add_networks(root, params): -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
