Nir Soffer has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/36263/4/vdsm/v2v.py File vdsm/v2v.py: Line 49 Line 50 Line 51 Line 52 Line 53 > you mean all the input ie the status and the name? Yes, all the info that we can get from the vm object. Line 107: if e is not None: Line 108: params['arch'] = e.get('arch') Line 109: Line 110: Line 111: def _add_disks(root, params, conn): > We do need the size in the verb (vdsm call) We can add _add_disk_info(conn, disk) that get the info for disk["alias"] volume and update disk["truesize"]. Then loop over collected disks for each vm and invoke this call. Line 112: params['disks'] = [] Line 113: disks = root.findall('.//disk[@type="file"]') Line 114: for disk in disks: Line 115: d = {} -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
