Shahar Havivi has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36263/3/vdsm/v2v.py File vdsm/v2v.py: Line 35: Line 36: Line 37: def get_external_vms(uri, username, password): Line 38: if not supported(): Line 39: return errCode["noimpl"] I think we are missing import here... I will send a fix in this patch Line 40: Line 41: conn = libvirtconnection.open_connection(uri=uri, Line 42: username=username, Line 43: passwd=password) -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
