Allon Mureinik has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/38021/1//COMMIT_MSG Commit Message: Line 17: are used now. Line 18: Line 19: Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Line 20: Signed-off-by: Ala Hino <[email protected]> Line 21: Bug-Url: https://bugzilla.redhat.com/1191549 IIUC, this does not solve the bug, it's just related to it. If so, you should use "Related-To:" instead of "Bug-Url:" http://gerrit.ovirt.org/#/c/38021/1/tests/miscTests.py File tests/miscTests.py: Line 897: self.assertNotEqual(m, None) Line 898: Line 899: self.assertEqual(m.group("bytes"), bytes) Line 900: self.assertEqual(m.group("seconds"), seconds) Line 901: Please remove the TWS Line 902: class PidExists(TestCaseBase): Line 903: def testPidExists(self): Line 904: """ Line 905: Test if pid given exists. -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
