Nir Soffer has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test ......................................................................
Patch Set 1: (2 comments) Nice, just refine the commit message and remove the trailing whitespace. http://gerrit.ovirt.org/#/c/38021/1//COMMIT_MSG Commit Message: Line 13: the parameters in the template with the corresponding values from Line 14: the output. Line 15: Line 16: Instead, template removed and outputs, in the format returned by dd, Line 17: are used now. I don't think this explains very good why this change is better. Try to make this text little shorter and do not describe the change since we can see the change in the code. Line 18: Line 19: Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Line 20: Signed-off-by: Ala Hino <[email protected]> Line 17: are used now. Line 18: Line 19: Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Line 20: Signed-off-by: Ala Hino <[email protected]> Line 21: Bug-Url: https://bugzilla.redhat.com/1191549 > IIUC, this does not solve the bug, it's just related to it. If so, you shou This is not even related to the bug, just general cleanup before we add a test for this bug. -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
