On 21 Aug 2007, at 05:05, John E. Malmberg wrote:
In Extract.pm, upper case options to commands must be enclosed in
double quotes. This seems to only affect the UNZIP command.
In 01_Archive-Extract.t, to compare directory components in VMS
syntax, the trailing "]" needs to be removed.
--- /rsync_root/perl/lib/Archive/Extract/t/01_Archive-Extract.t Mon
May 28 07:33:43 2007
+++ lib/Archive/Extract/t/01_Archive-Extract.t Thu Aug 16 23:06:18
2007
@@ -362,6 +362,10 @@
### if something went wrong with
determining the out
### path, don't go deleting stuff.. might
be Really Bad
my $out_re = quotemeta( $OutDir );
+
+ # Remove the directory terminator from regex
+ my $out_re = s/\\\]// if IS_VMS;
+
if( $ae->extract_path !~ /^$out_re/ ) {
ok( 0, "Extractpath WRONG (".$ae-
>extract_path.")");
skip( "Unsafe operation -- skip
cleanup!!!" ), 1;
This doesn't seem to do at all what you intend -- it *redefines* $out_re
to be the result of a substitution on $_... what did you mean to do
exactly?
And shouldn't this be done in the library rather than in the test suite?
-- Jos
