Thanks for the patch. A couple of comments: 1) I don't like iprimarykeyprovider, or whatever it ends up being called, extend idataprovider. It can be its own interface that your own impl of idataprovider can chose to ALSO implement.
2) If we do (1) we can get rid of the duplicate onbeginrequest methods by using an impl of iprimarykeyprovider that uses the long counter. On a more general point what do people think about this approach? (splitting primarykey() into iprimarykeyprovider) -Igor > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 10, 2005 6:06 PM > To: [email protected] > Subject: Re: [Wicket-user] DataView: IDataProvider.primaryKey() vote > > Did entertain myself with the idea and tried to implement it. > Attached is a roughly tested patch. > > I changed the name of IPrimaryKeyProvider to IPrimaryKeyDataProvider. > > I also did replace the Map in DataView.onRender() with an array. > > Christian > > On Wed, 10 Aug 2005 14:35:45 -0700, Igor Vaynberg > <[EMAIL PROTECTED]> > wrote: > > > Alrite, without spending too much more time on this, > entartain this idea: > > Move primarykey to IPrimaryKeyProvider { String primaryKey() } > > > > The dataview can do an instanceof check on the impl of > IDataProvider, > > if it implements iprimarykeyprovider use that otherwise use > a generic > > counter. > > > > > > -Igor > > > > > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
