Gili, please don't post without actually following the discussion and looking at the code AND TRYING TO UNDERSTAND WHAT WE ARE TALKING ABOUT! I don't need you to recite java 101 mantras for me which by the way have NOTHING TO DO with our discussion here.
-Igor > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Gili > Sent: Friday, September 02, 2005 10:50 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > > So this gets back to my original point, if you find you > have to do this sort of thing in your subclass it usually > points to bad design. Try redesigning it so this does not happen. > > I'm not claiming to have a solution ready for you, but > as any good design by contract or object oriented programming > book will tell you, subclasses *must* ahere to the superclass > contract. > > Gili > > Igor Vaynberg wrote: > > Well, if you wouldve actually looked at what we were > talking about you > > wouldve seen that those methods are needed in the base > class and were > > there from day one. The pageable subclass makes them > obsolete within > > its context so they throw exceptions when used. > > > > -Igor > > > > > > > >>-----Original Message----- > >>From: [EMAIL PROTECTED] > >>[mailto:[EMAIL PROTECTED] On Behalf Of Gili > >>Sent: Friday, September 02, 2005 9:45 PM > >>To: wicket-user@lists.sourceforge.net > >>Subject: Re: [Wicket-user] PageableGridDataView > >> > >> > >> What are you talking about? I wasn't saying you should decrease > >>visibility of methods in a subclass. I said you shouldn't > be declaring > >>them in the base class to begin with. > >> > >>Gili > >> > >>Igor Vaynberg wrote: > >> > >>>Well once you figure out how to decrease visibility of > methods in a > >>>subclass let me know and I will be happy to do that. > >>> > >>>-Igor > >>> > >>> > >>> > >>> > >>>>-----Original Message----- > >>>>From: [EMAIL PROTECTED] > >>>>[mailto:[EMAIL PROTECTED] On Behalf Of Gili > >>>>Sent: Friday, September 02, 2005 3:05 PM > >>>>To: wicket-user@lists.sourceforge.net > >>>>Subject: Re: [Wicket-user] PageableGridDataView > >>>> > >>>> > >>>> What is the reason? The new method sounds very anti-OOP to me. > >>>>Usually one layers functionality using interfaces. > >>>>Stuffing them all into the base class but having them throw > >> > >>exceptions > >> > >>>>when "disabled" sounds a lot like a flat object model to me. > >>>> > >>>>Gili > >>>> > >>>>Johan Compagner wrote: > >>>> > >>>> > >>>>>that is something we had.. and want to get rid of i think.. > >>>>> > >>>>>johan > >>>>> > >>>>> > >>>>>Gili wrote: > >>>>> > >>>>> > >>>>> > >>>>>>Igor Vaynberg wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>>Yes the support delegate is lazily created. > >>>> > >>>>Setcurrentpage() throws > >>>> > >>>> > >>>>>>>illegalstateexception if paging is disabled. > >>>>>> > >>>>>> > >>>>>> Sounds like an anti-pattern to me. Why don't you have a base > >>>>>>class without Pagable support and a subclass that is > >>>> > >>>>Pagable (always) > >>>> > >>>> > >>>>>>with these methods. > >>>>>> > >>>>>>Gili > >>>>>> > >>>>>> > >>>>>>------------------------------------------------------- > >>>>>>SF.Net email is Sponsored by the Better Software > >> > >>Conference & EXPO > >> > >>>>>>September 19-22, 2005 * San Francisco, CA * Development > Lifecycle > >>>>>>Practices Agile & Plan-Driven Development * Managing > >>>> > >>>>Projects & Teams > >>>> > >>>> > >>>>>>* Testing & QA Security * Process Improvement & Measurement * > >>>>>>http://www.sqe.com/bsce5sf > >>>>>>_______________________________________________ > >>>>>>Wicket-user mailing list > >>>>>>Wicket-user@lists.sourceforge.net > >>>>>>https://lists.sourceforge.net/lists/listinfo/wicket-user > >>>>>> > >>>>> > >>>>> > >>>>>------------------------------------------------------- > >>>>>SF.Net email is Sponsored by the Better Software > Conference & EXPO > >>>>>September 19-22, 2005 * San Francisco, CA * Development > Lifecycle > >>>>>Practices Agile & Plan-Driven Development * Managing > >>>> > >>>>Projects & Teams > >>>> > >>>> > >>>>>* Testing & QA Security * Process Improvement & Measurement * > >>>>>http://www.sqe.com/bsce5sf > >>>>>_______________________________________________ > >>>>>Wicket-user mailing list > >>>>>Wicket-user@lists.sourceforge.net > >>>>>https://lists.sourceforge.net/lists/listinfo/wicket-user > >>>>> > >>>> > >>>>-- > >>>>http://www.desktopbeautifier.com/ > >>>> > >>>> > >>>>------------------------------------------------------- > >>>>SF.Net email is Sponsored by the Better Software > Conference & EXPO > >>>>September 19-22, 2005 * San Francisco, CA * Development Lifecycle > >>>>Practices Agile & Plan-Driven Development * Managing > >> > >>Projects & Teams > >> > >>>>* Testing & QA Security * Process Improvement & Measurement * > >>>>http://www.sqe.com/bsce5sf > >>>>_______________________________________________ > >>>>Wicket-user mailing list > >>>>Wicket-user@lists.sourceforge.net > >>>>https://lists.sourceforge.net/lists/listinfo/wicket-user > >>>> > >>>> > >>>> > >>> > >>> > >>> > >>> > >>> > >>>------------------------------------------------------- > >>>SF.Net email is Sponsored by the Better Software Conference & EXPO > >>>September 19-22, 2005 * San Francisco, CA * Development Lifecycle > >>>Practices Agile & Plan-Driven Development * Managing > >> > >>Projects & Teams > >> > >>>* Testing & QA Security * Process Improvement & Measurement * > >>>http://www.sqe.com/bsce5sf > >>>_______________________________________________ > >>>Wicket-user mailing list > >>>Wicket-user@lists.sourceforge.net > >>>https://lists.sourceforge.net/lists/listinfo/wicket-user > >>> > >> > >>-- > >>http://www.desktopbeautifier.com/ > >> > >> > >>------------------------------------------------------- > >>SF.Net email is Sponsored by the Better Software Conference & EXPO > >>September 19-22, 2005 * San Francisco, CA * Development Lifecycle > >>Practices Agile & Plan-Driven Development * Managing > Projects & Teams > >>* Testing & QA Security * Process Improvement & Measurement * > >>http://www.sqe.com/bsce5sf > >>_______________________________________________ > >>Wicket-user mailing list > >>Wicket-user@lists.sourceforge.net > >>https://lists.sourceforge.net/lists/listinfo/wicket-user > >> > >> > >> > > > > > > > > > > > > ------------------------------------------------------- > > SF.Net email is Sponsored by the Better Software Conference & EXPO > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle > > Practices Agile & Plan-Driven Development * Managing > Projects & Teams > > * Testing & QA Security * Process Improvement & Measurement * > > http://www.sqe.com/bsce5sf > > _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > -- > http://www.desktopbeautifier.com/ > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development > Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * > Testing & QA > Security * Process Improvement & Measurement * > http://www.sqe.com/bsce5sf > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
