On Thu, Jun 2, 2011 at 9:20 AM, Robert Leverington <rob...@rhl.me.uk> wrote: > I reject the notion that we need a change in our review processes. > Empirical evidence shows that when staff time is assigned to it, our > code review system *does* work. (Of course there are always minor > changes that would improve efficiency, such as automating some of the > reporting tasks that have traditionally been done manually.) > I agree that it's worth trying to add staff time without materially changing the process, see how that works, then change things as needed.
> Updates on how this is going would be nice, as again it took MZMcBride > to bring it up before anyone senior posted about it - and this is still > the big issue for volunteer developers. > FWIW, I was planning to bring this up at the staff meeting following the Berlin hackathon. I said to a number of people that I wanted to have a discussion about code review, both before and during the event. This didn't end up happening, partly because some felt that people that weren't around should be involved, or that the entire discussion should be had in public, and partly because we were doing all sorts of other things. I think MZ knew about my plans and the lack of a post-conference update saying "here's the outcome of our discussion, what do you think" may have driven him to bring this up. I care about this issue, and I agree with MZ on most of the basics, but I'm also a busy guy who took some time off after the conference to focus on school. So having said the obligatory "but I care too!" thing, you are right that it seems, at least to people outside the office (both staff and non-staff: apparently there are lots of hallway discussions about CR these days, but they happen thousands of miles from my desk so working for WMF doesn't help me there), that there isn't a lot of attention given to this. Whether that's actually the case or just the impression that's being created due to lack of communication doesn't matter all that much; we can and should fix it. Roan Kattouw (Catrope) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
