I'd still prefer JSON for offline/non-PHP use. I'm not sure it's a huge deal though.
Bugzilla from niklas.laxst...@gmail.com wrote: > > Big thank you for everyone who already looked and tested the code, > especially to Aaron. I have fixed the few issues that have come up. > > Have we reached to an agreement to serialize the parameters instead of > formatting them with JSON? I am going commit code that actually > creates log entries using this new system, so I'd rather be sure we > are comfortable with what we have chosen, to avoid unnecessary mix of > different formats in the database. > > -Niklas > > On 8 September 2011 20:00, Niklas Laxström <niklas.laxst...@gmail.com> > wrote: >> On 8 September 2011 17:57, Daniel Friesen <li...@nadir-seen-fire.com> >> wrote: >>> On 11-09-08 04:25 AM, Niklas Laxström wrote: >>>> On 8 September 2011 13:36, Max Semenik <maxsem.w...@gmail.com> wrote: >>>>> On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz <aschulz4...@gmail.com> >>>>> wrote: >>>>> >>>>>> Yay for log_params. I was thinking JSON would be appropriate here, so >>>>>> I'm >>>>>> glat to see that. >>>>>> >>>>>> >>>>> Even though data in those fields is small enough, can >>>>> serialize()/unserialize() be used instead? It's faster and doesn't >>>>> require >>>>> the mess of ServicesJSON to work correctly. >>>> Do those cause actual problems or is it just matter of preference? In >>>> my opinion JSON is much better for anyone who wants to dig the logs >>>> without using PHP. Also, is (un)serialize guaranteed to be stable >>>> across PHP versions? >>>> >>>> -Niklas >>> We already use serialize in HistoryBlob/Revision, the job queue, >>> caching, file metadata, the localization cache, ... >>> >>> So if you add any new fields to the db you should really stick to >>> (un)serialize. >>> We're already using serialize everywhere and we even use binary storage >>> which is troublesome for anyone trying to stare at the database with >>> most phpmyadmin installs. People being minorly inconvenienced when >>> reading the database raw is the last of our issues. >>> If you want to argue the irrelevant minority that would be slightly >>> inconvenienced reading the database raw I'll argue the irrelevant >>> minority that would be slightly inconvenienced trying to do db queries >>> to mw code externally and have to parse json which isn't as simple as >>> (un)serialize. >>> ;) I'll also wager that HipHop makes the gap in speed between >>> (un)serialize and json farther. >> >> Very well, r96585. > > > > -- > Niklas Laxström > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > > -- View this message in context: http://old.nabble.com/Requests-about-log-system-tp32396608p32434885.html Sent from the Wikipedia Developers mailing list archive at Nabble.com. _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
