I agree with Antoine. Commit messages are part of the permanent history of this project. From now until MediaWiki doesn't exist anymore, anybody can come and look at the change history and the commit messages that go with them. Now you might ask what the possibility is of somebody ever coming across a single commit message that has a typo in it, but when you're using git-blame, git-bisect, or other similar tools, it's very possible.
Also, a -1 is not a -2. It won't block the change from being merged; it's just a notification that something needs to be fixed, however minor. I'm still in favor of requiring every tag line to contain either (bug > nnnnn) or > (minor), so people are reminded that bugs should be filed and linked for > anything that is not trivial. That's not what I want to discuss here - it > just > strikes me as much more relevant than typos, yet people don't seem to be > too > keen to enforce that. I'm not so sure about *every* commit, but I definitely agree that this needs to be enforced more. If you're fixing something or adding a new feature, there should be a bug to go with it. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Tue, Jan 15, 2013 at 8:37 AM, Antoine Musso <hashar+...@free.fr> wrote: > Le 15/01/13 12:44, Jeroen De Dauw wrote: > > > > I have observed a difference in opinion between two groups of people on > > gerrit, which unfortunately is causing bad blood on both sides. I'm > > therefore interested in hearing your opinion about the following > scenario: > > > > Someone makes a sound commit. The commit has a clear commit message, > though > > there is a single typo in it. Is it helpful to -1 the commit because of > the > > typo? > > Yup -1 anything that is wrong, even if it is the must trivial error ever > encountered. We have a pre commit review workflow exactly for that. > > If you feel brave enough, you could edit it yourself: > - download the change > - amend it > - sent patchset back > - leave a message (fixed typo) > - removed yourself from the reviewer list > Done :-] > > > I wanted to have a spell checker to lint the commit message, but > eventually gave up because of the number of false positives. > > > -- > Antoine "hashar" Musso > > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
