Le 18/06/2015 16:18, Brad Jorsch (Anomie) a écrit :
> On Thu, Jun 18, 2015 at 9:32 AM, Jon Robson <jdlrob...@gmail.com> wrote:
>> Smaller commits generally are better
>
>
> I'm going to call red herring here. Whether or not smaller commits are
> really better, one patch that does
>
> + if ( detectOldInput( $input ) ) {
> + $input = upgradeInput( $input );
> + // wfDeprecated( "You used the old input style!" );
> + }
>
> then a followup that does
>
> - // wfDeprecated( "You used the old input style!" );
> + wfDeprecated( "You used the old input style!" );
>
> to be merged 1 second later[1] isn't an example.
Though the second patch should have much more content:
- potentially an announcement (think about MW api.php deprecations)
- migration documentation
- a release note entry
And so on. So the first patch let devs catch up, the second one is
preparing the proper release/deprecation of the feature.
> [1]: Assuming Jenkins gets a whole lot faster about merging stuff ;)
Time to get MediaWiki test suite faster :-] It needs a lot of
refactoring to stop exercising the whole stack for every single "unit"
test :-D
--
Antoine "hashar" Musso
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
