gasol wrote:
> Well based on the earlier patch, dont have time atm to write a "real" one
>
> if (event->message_type == net_active_window) { // ACHTUNG! Lazy evaluation!
> if(event->data.l[0] == 2 || ALLOW_ACTIVE_WINDOW_CHANGE(wwin) ||
> wwin->frame->workspace == wwin->screen_ptr->current_workspace)
> {
> wNETWMShowingDesktop(scr, False);
> wMakeWindowVisible(wwin);
> }
> }
>
> So we allow the change of the active window IF: its on the _same_
> desktop OR if its explicitly sent from an pager OR we have made an
> exception and lets a certain application change active window...
>
> The third criteria would be added to our TODO list, if i get some time
> over this weekend i could start snooping around how to do it...
Do you think that would solve all the earlier worries? I guess so.
It seems the only remaining piece is the ALLOW_ACTIVE_WINDOW_CHANGE
macro, for which you also have a good starting point (from your other
email, thanks for the hint btw. That helps!)
> Dont get me wrong i think its great that patches are coming in, but a
> little discussion about the side effects are always a good thing! At
> least before they are commited...
Ok, so that would be my fault. Sorry about that and I will take more
care and not push patches on the same day. But I will not wait more
than a week if nobody raises concerns and I think the change is good.
In this case it was a bit premature, but at least we have a sane
base behavior now, which can be tweaked for special cases later
(for pagers or whatever).
--
To unsubscribe, send mail to [email protected].
