On Tue 25.Aug'09 at 14:38:47 +0200, Martin Dietze wrote: > On Tue, August 25, 2009, Carlos R. Mafra wrote: > > > > Dont get me wrong i think its great that patches are coming in, but a > > > little discussion about the side effects are always a good thing! At > > > least before they are commited... > > > > Ok, so that would be my fault. Sorry about that and I will take more > > care and not push patches on the same day. But I will not wait more > > than a week if nobody raises concerns and I think the change is good. > > I agree with both of you. One could think of a development > branch for changes like this, however I do hesitate a bit to > seriously suggest this as a single branch already takes lots of > time to maintain.
Actually for me it would be trivial to have a 'next' branch in the repo, really. I think it could be even the preferred way to go, as I could put stuff there on the same day for others to test too and mainly to _improve_ the situation. So if someone complains about something in patches sitting in 'next', they can send patches on top of if and I will squash them together when (and if) merging the patches into 'master'. That is not too much overhead for me, I can do it. If after some time sitting on 'next' without any complains/patches from interested people, and if I think the patches are worth having (I am -- after all -- a wmaker user too), then they will go to 'master'. What I do not want is unneeded latency to go forward. If I keep on waiting here and everybody keeps on waiting there, nobody goes anywhere. But mistakes happen, nobody is perfect and we are all doing this out of our passion for having a little bit better wmaker for all of us (while learning interesting new things in the process). So _nothing_ is written on stone! 'git revert' is as simple as it can get, patches can be applied on top of others and all that. But I don't want people to think that I will be responsible for fixing other people's bug in the git tree (although I can try if I get interested). That is mainly a place where people's work can go without burden, so we should all help each other in the list and try to get more knowledge and make the code easier and cleaner for everybody to read and understand. I think that is already happening, which is good. So, I've just put a 'next' branch up there. It contains Johann's "Left right maximize" patch and Gilbert's "Show application name when killing it" (which I think needs a bit more work about the appicon.c changes and have already asked Gilbert's input on that). Hail Window Maker! PS: I am, of course, open to any kind of suggestions and criticism. And of course I would love to know what Alfredo and Dan think about it and if they have some recommendations to give, because ultimately they have the right/power of veto over all this. -- To unsubscribe, send mail to [email protected].
