On Sat, 22 Aug 2015, Josip Deanovic wrote:
On Saturday 2015-08-22 16:53:56 Carlos R. Mafra wrote:
Which feature was removed that you are missing?
The one I am talking for over a year now. :-)
Also app icon caching was broken around the same time. The app icon cache
in CachedPixmaps was meant to store icons retrieved from X clients so the
dock or clip can display those when the client is not running like after
startup. The cache should contain only such icons and the path should
never appear in WMWindowAttributes because the cache is an internal thing
used to look up icons not otherwise available. If you look at your
WMWindowAttributes now it is full of entries referring to the cache that
should not be there and if you look at the cache dir you'll find a lot of
icons from all apps you've ever started while there should be only the
few docked ones that use client side icons. Also the cache is never
cleaned up only new icons are added to it.
The icon handling code was a bit complicated before but worked (maybe
cache cleanup was broken before) until overzealous simplification attempts
have messed it up so much that it is now difficult to untangle. Even more
so because the object oriented design was also messed up by renaming and
moving methods around so now it is not clear what object methods these
functions were meant to be.
I think the principles to follow should be:
1. K.I.S.S.
2. If ain't broke don't fix it.
3. If you don't understand it don't touch it. (That is, think about all
possible implications of your proposed change because it may work with
your particular settings but a lot of things can be set by
preferences.)
Regards,
BALATON Zoltan
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
