On Mon, 8 Apr 2002, Matthias Saou wrote:

> [dude@python dude]$ ls -l /usr/games/bin/xmame.xgl
> -rwxr-s--x   1 root   games  13376940 Apr  8 21:08 /usr/games/bin/xmame.xgl
>
> Apparently gRustibus expects to be able to read the xmame binary, which was
> impossible for mine, as packages with suid/sgid binaries often remove the
> read bit and leave only the execution one!!!

I consider this a bug in gRustibus.  Not only does it expect to be able to
read the xmame binary, but it leaks a file descriptor and file handle.

In line 619 of mameio.c, you have:

        if (!fopen(general_prefs.xmame_exe, "r")) {

which should probably be:

        if (!access(general_prefs.xmame_exe, X_OK)) {

(BTW, this is gRustibus 0.43 I'm looking at.)

Carl Fongheiser
[EMAIL PROTECTED]


_______________________________________________
Xmame mailing list
[EMAIL PROTECTED]
http://toybox.twisted.org.uk/mailman/listinfo/xmame

Reply via email to