* Carl Fongheiser <[EMAIL PROTECTED]>:
> I consider this a bug in gRustibus. Not only does it expect to be able to
> read the xmame binary, but it leaks a file descriptor and file handle.
>
> In line 619 of mameio.c, you have:
>
> if (!fopen(general_prefs.xmame_exe, "r")) {
>
> which should probably be:
>
> if (!access(general_prefs.xmame_exe, X_OK)) {
>
> (BTW, this is gRustibus 0.43 I'm looking at.)
It's kind of embarrassing, but I didn't know about the access() call. I
have fixed this bug and a couple of others like it in cvs now. xmame
executables without the readable bit set are no longer a problem.
Thanks for the tip.
Kjetil
--
Quidquid latine dictum sit, altum viditur
PGP fingerprint: 9130 802B B7F3 DB91 81B0 007D 0ED1 E76D 4B70 ABA6
_______________________________________________
Xmame mailing list
[EMAIL PROTECTED]
http://toybox.twisted.org.uk/mailman/listinfo/xmame
