[
https://issues.apache.org/jira/browse/YARN-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551034#comment-16551034
]
Wangda Tan commented on YARN-8418:
----------------------------------
[~bibinchundatt],
{quote}As part of YARN-4984 we disabled the thread / not sure was a leak..
{quote}
I see, I checked history of related fixes.
there're 3 issues related to the problem:
1) YARN-4697 bounds maximum #threads can be used by LogAggregationService.
2) YARN-4325 will fix a problem that completed app event will be sent to
LogAggregationService again
3) YARN-4984 will fix a corner case that even creation of log aggregation app
dir fails, LogAggregationService still use a new thread to do following works.
Given we have #1, I think #3 is not a big issue here and we need it to do app
cleanup and it is also needed to upload logs once new token received. Now I'm
convinced that we should revert part of changes in YARN-4984 and do right fix
here.
> App local logs could leaked if log aggregation fails to initialize for the app
> ------------------------------------------------------------------------------
>
> Key: YARN-8418
> URL: https://issues.apache.org/jira/browse/YARN-8418
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Critical
> Attachments: YARN-8418.001.patch, YARN-8418.002.patch,
> YARN-8418.003.patch, YARN-8418.004.patch
>
>
> If log aggregation fails init createApp directory container logs could get
> leaked in NM directory
> For log running application restart of NM after token renewal this case is
> possible/ Application submission with invalid delegation token
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
