[ 
https://issues.apache.org/jira/browse/YARN-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555144#comment-16555144
 ] 

Bibin A Chundatt commented on YARN-8418:
----------------------------------------

Thank you [~suma.shivaprasad] for understanding 

 
{quote}if the aggregatorWrapper runnable runs before the enableAppAggregators 
is called for that app during credential updates
{quote}
AggregatorImpl thread is  infinite loop . And aggregation is notified on 
interval or on application finish. So you are correct, if token renewed event 
is not received before application finish then logs will be deleted. Also if 
event is delayed when aggregator won't be found. But this case i feel very rare 
. Since we should received new token in first heartbeat .

Additionally delayed deletion suggestion for those cases i had suggested. Will 
handle in separate jira..

Any other suggestion ??

 
{quote}Applications dont get removed from invalidTokenApps except in 
enableAppAggregators
{quote}
Nice catch, Will udpate in next patch.

 

 

 

 

 

> App local logs could leaked if log aggregation fails to initialize for the app
> ------------------------------------------------------------------------------
>
>                 Key: YARN-8418
>                 URL: https://issues.apache.org/jira/browse/YARN-8418
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.8.0, 3.0.0-alpha1
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Critical
>         Attachments: YARN-8418.001.patch, YARN-8418.002.patch, 
> YARN-8418.003.patch, YARN-8418.004.patch, YARN-8418.005.patch
>
>
> If log aggregation fails init createApp directory container logs could get 
> leaked in NM directory
> For log running application restart of NM after token renewal this case is 
> possible/  Application submission with invalid delegation token



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to