[
https://issues.apache.org/jira/browse/YARN-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553817#comment-16553817
]
Bibin A Chundatt commented on YARN-8418:
----------------------------------------
Thank you [~suma.shivaprasad] for looking in to patch
{quote}
Wouldnt this cause leaks in case of other Exception cases (not Invalid token
cases)
{quote}
{{aggregatorWrapper}} thread takes cares of closing once aggregator thread is
compelte
{code}
// Schedule the aggregator.
Runnable aggregatorWrapper = new Runnable() {
public void run() {
try {
appLogAggregator.run();
} finally {
appLogAggregators.remove(appId);
closeFileSystems(userUgi);
}
}
};
{code}
{quote}
when the scheduled aggregator runs?
{quote}
Once exception we have disableFlag per aggregator . So if aggregator is
disabled then the upload will be skipped and only the postCleanUp is done.
{{AppLogAggregatorImpl#run()}}
> App local logs could leaked if log aggregation fails to initialize for the app
> ------------------------------------------------------------------------------
>
> Key: YARN-8418
> URL: https://issues.apache.org/jira/browse/YARN-8418
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Critical
> Attachments: YARN-8418.001.patch, YARN-8418.002.patch,
> YARN-8418.003.patch, YARN-8418.004.patch, YARN-8418.005.patch
>
>
> If log aggregation fails init createApp directory container logs could get
> leaked in NM directory
> For log running application restart of NM after token renewal this case is
> possible/ Application submission with invalid delegation token
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
