[ 
https://issues.apache.org/jira/browse/YARN-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825976#comment-13825976
 ] 

Mayank Bansal commented on YARN-1266:
-------------------------------------

[~zjshen] thanks for review

bq. IMHO, application_base_protocol.proto should not be necessary, because the 
base interface is to extract the common code, not to be directly used from the 
RPC interface. 
We need it as service impl needs it.

bq. 2. ApplicationClientProtocolPB and ApplicationHistoryProtocolPB don't need 
to extend ApplicationBaseProtocolService.BlockingInterface
Done.

Thanks,
Mayank

> inheriting Application client and History Protocol from base protocol and 
> implement PB service and clients.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1266
>                 URL: https://issues.apache.org/jira/browse/YARN-1266
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1266-1.patch, YARN-1266-2.patch, YARN-1266-3.patch, 
> YARN-1266-4.patch
>
>
> Adding ApplicationHistoryProtocolPBService to make web apps to work and 
> changing yarn to run AHS as a seprate process



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to