[ 
https://issues.apache.org/jira/browse/YARN-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826759#comment-13826759
 ] 

Vinod Kumar Vavilapalli commented on YARN-1266:
-----------------------------------------------

Adding to Zhijie's coments:
 - I hope this is a compatible change - moving methods to a super-interface. 
Can you please check?
 - Mark application_base_protocol.proto and ApplicationBaseProtocol as some 
kind of internal interfaces not to be used directly? May be by making them only 
package private and protected or something. Along with that we'll need to put 
correct audience and visibility annotations.
 - Similarly for the client and service wrappers.



> inheriting Application client and History Protocol from base protocol and 
> implement PB service and clients.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1266
>                 URL: https://issues.apache.org/jira/browse/YARN-1266
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1266-1.patch, YARN-1266-2.patch, YARN-1266-3.patch, 
> YARN-1266-4.patch
>
>
> Adding ApplicationHistoryProtocolPBService to make web apps to work and 
> changing yarn to run AHS as a seprate process



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to