[ 
https://issues.apache.org/jira/browse/YARN-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828376#comment-13828376
 ] 

Vinod Kumar Vavilapalli commented on YARN-1266:
-----------------------------------------------

Sigh, I don't like this overall if can't reuse everywhere. Sorry to let you 
lose a wild goose chase.

You are going to kill me when I say this, but it seems like we should just 
commit your first patch.

Because this neither-here-nor-there code-reuse seems not much useful. The 
original reason why i asked this is so that clients can seamlessly cross over 
like in MR between RM and AHS. But it seems like clients have to know which 
protocol they are talking to.

This half-reuse is more confusing for new devs who see this code for the first 
time.

> inheriting Application client and History Protocol from base protocol and 
> implement PB service and clients.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1266
>                 URL: https://issues.apache.org/jira/browse/YARN-1266
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1266-1.patch, YARN-1266-2.patch, YARN-1266-3.patch, 
> YARN-1266-4.patch, YARN-1266-5.patch
>
>
> Adding ApplicationHistoryProtocolPBService to make web apps to work and 
> changing yarn to run AHS as a seprate process



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to