Integrated: JDK-8327474 Review use of java.io.tmpdir in jdk tests
On Mon, 18 Mar 2024 16:47:24 GMT, Bill Huang wrote: > This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary directory, which > can affect the system's storage and potentially influence subsequent test > runs. > > Our review identified that several tests create temporary files or socket > files without ensuring their removal post-execution. > - Direct calls to java.io.File.createTempFile and > java.nio.file.Files.createTempFile without adequate cleanup. > - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not > explicitly removing socket files post-use. This pull request has now been integrated. Changeset: 375bfac8 Author:Bill Huang URL: https://git.openjdk.org/jdk/commit/375bfac8e7ff3f871e2d986876f91a5fba200c83 Stats: 193 lines in 11 files changed: 66 ins; 13 del; 114 mod 8327474: Review use of java.io.tmpdir in jdk tests Reviewed-by: michaelm, jpai - PR: https://git.openjdk.org/jdk/pull/18352
Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v5]
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary directory, which > can affect the system's storage and potentially influence subsequent test > runs. > > Our review identified that several tests create temporary files or socket > files without ensuring their removal post-execution. > - Direct calls to java.io.File.createTempFile and > java.nio.file.Files.createTempFile without adequate cleanup. > - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not > explicitly removing socket files post-use. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/18352/files - new: https://git.openjdk.org/jdk/pull/18352/files/0f4130a9..81244609 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18352=04 - incr: https://webrevs.openjdk.org/?repo=jdk=18352=03-04 Stats: 30 lines in 2 files changed: 12 ins; 5 del; 13 mod Patch: https://git.openjdk.org/jdk/pull/18352.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18352/head:pull/18352 PR: https://git.openjdk.org/jdk/pull/18352
Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v4]
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary directory, which > can affect the system's storage and potentially influence subsequent test > runs. > > Our review identified that several tests create temporary files or socket > files without ensuring their removal post-execution. > - Direct calls to java.io.File.createTempFile and > java.nio.file.Files.createTempFile without adequate cleanup. > - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not > explicitly removing socket files post-use. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Update test/jdk/java/nio/channels/unixdomain/Bind.java Co-authored-by: Andrey Turbanov - Changes: - all: https://git.openjdk.org/jdk/pull/18352/files - new: https://git.openjdk.org/jdk/pull/18352/files/2517f756..0f4130a9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18352=03 - incr: https://webrevs.openjdk.org/?repo=jdk=18352=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18352.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18352/head:pull/18352 PR: https://git.openjdk.org/jdk/pull/18352
Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary directory, which > can affect the system's storage and potentially influence subsequent test > runs. > > Our review identified that several tests create temporary files or socket > files without ensuring their removal post-execution. > - Direct calls to java.io.File.createTempFile and > java.nio.file.Files.createTempFile without adequate cleanup. > - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not > explicitly removing socket files post-use. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Fixed potential NPE issues. - Changes: - all: https://git.openjdk.org/jdk/pull/18352/files - new: https://git.openjdk.org/jdk/pull/18352/files/620f9259..2517f756 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18352=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18352=01-02 Stats: 11 lines in 4 files changed: 5 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/18352.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18352/head:pull/18352 PR: https://git.openjdk.org/jdk/pull/18352
Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v2]
On Thu, 21 Mar 2024 15:06:58 GMT, Jaikiran Pai wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments
>
> test/jdk/java/util/zip/ZipFile/ZeroDate.java line 95:
>
>> 93:
>> 94: // ensure that the archive is still readable, and the date is
>> 1979-11-30
>> 95: Path path = Utils.createTempFile("out", ".zip");
>
> So it looks like the test library has this utility method which allows to
> create temporary files within the jtreg scratch directory. Perhaps we should
> use it then. Having said that, is there a reason why one test method in this
> test now uses `Files.createTempFile(...)` and this other test method uses
> `Utils.createTempFile(...)`?
Yes, you are right. We don't need explicit deletion for these files by using
this util method, Utils.createTempFile.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1534290137
Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v2]
On Thu, 21 Mar 2024 14:41:36 GMT, Jaikiran Pai wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments
>
> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java line 57:
>
>> 55:
>> 56: File flagsFile = File.createTempFile("CheckOriginFlags",
>> null);
>> 57: flagsFile.deleteOnExit();
>
> Hello Bill, jtreg uses a scratch directory when running tests. When a test is
> launched, the current working directory points to the scratch directory for
> the test that's currently executing. jtreg manages the lifecycle of scratch
> directories and even cleans them up (as necessary).
> Would it instead be better to just create the temporary file within the jtreg
> scratch directory (represented by the current working directory)? That way
> you could just do:
>
>
> File flagsFile = Files.createTempFile(Path.of("."), "CheckOriginFlags",
> null).toFile();
>
> and don't need any explicit deletions?
Hi Jaikiran, I think both solutions work for this bug. I personally prefer to
place the files in the scratch directory for the ease of debugging.
In addition, for this specific test, I am considering using
File.createTempFile("CheckOriginaFlags", null, Path.of(".").toFile) instead of
Files.createTempFile for consistency purposes, as Files.createTempFile may have
more restrictive access permissions.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1534283105
Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v2]
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary directory, which > can affect the system's storage and potentially influence subsequent test > runs. > > Our review identified that several tests create temporary files or socket > files without ensuring their removal post-execution. > - Direct calls to java.io.File.createTempFile and > java.nio.file.Files.createTempFile without adequate cleanup. > - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not > explicitly removing socket files post-use. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments - Changes: - all: https://git.openjdk.org/jdk/pull/18352/files - new: https://git.openjdk.org/jdk/pull/18352/files/8472c31f..620f9259 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18352=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18352=00-01 Stats: 136 lines in 5 files changed: 36 ins; 13 del; 87 mod Patch: https://git.openjdk.org/jdk/pull/18352.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18352/head:pull/18352 PR: https://git.openjdk.org/jdk/pull/18352
RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests
This task addresses an essential aspect of our testing infrastructure: the proper handling and cleanup of temporary files and socket files created during test execution. The motivation behind these changes is to prevent the accumulation of unnecessary files in the default temporary directory, which can affect the system's storage and potentially influence subsequent test runs. Our review identified that several tests create temporary files or socket files without ensuring their removal post-execution. - Direct calls to java.io.File.createTempFile and java.nio.file.Files.createTempFile without adequate cleanup. - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not explicitly removing socket files post-use. - Commit messages: - Clean up temporary files after tests complete. Changes: https://git.openjdk.org/jdk/pull/18352/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18352=00 Issue: https://bugs.openjdk.org/browse/JDK-8327474 Stats: 42 lines in 11 files changed: 20 ins; 1 del; 21 mod Patch: https://git.openjdk.org/jdk/pull/18352.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18352/head:pull/18352 PR: https://git.openjdk.org/jdk/pull/18352
Integrated: JDK-8311961 Update Manual Test Groups for ATR JDK22
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote: > Updated jdk_core_manual test groups. This pull request has now been integrated. Changeset: 4c0f6c61 Author: Bill Huang URL: https://git.openjdk.org/jdk/commit/4c0f6c6105a8c7046cc4556d23272750bd9f7682 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8311961: Update Manual Test Groups for ATR JDK22 Reviewed-by: msheppar - PR: https://git.openjdk.org/jdk/pull/16531
RFR: JDK-8311961 Update Manual Test Groups for ATR JDK22
Updated jdk_core_manual test groups. - Commit messages: - JDK-8311961 Update Manual Test Groups for ATR JDK22 Changes: https://git.openjdk.org/jdk/pull/16531/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16531=00 Issue: https://bugs.openjdk.org/browse/JDK-8311961 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/16531.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16531/head:pull/16531 PR: https://git.openjdk.org/jdk/pull/16531
Integrated: JDK-8295859 Update Manual Test Groups
On Thu, 2 Mar 2023 21:34:28 GMT, Bill Huang wrote: > The purpose of this task is to add the difference between -manual jdk_core > and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order > to streamline the manual test execution process, a new test group called > jdk_core_manual_human has been created for manual tests that demand extra > preparation or test input. This pull request has now been integrated. Changeset: 87017b51 Author:Bill Huang URL: https://git.openjdk.org/jdk/commit/87017b5199522bb26f0225b60fbbc00df255ad2a Stats: 20 lines in 1 file changed: 11 ins; 4 del; 5 mod 8295859: Update Manual Test Groups Reviewed-by: msheppar - PR: https://git.openjdk.org/jdk/pull/12840
Re: RFR: JDK-8295859 Update Manual Test Groups [v3]
> The purpose of this task is to add the difference between -manual jdk_core > and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order > to streamline the manual test execution process, a new test group called > jdk_core_manual_human has been created for manual tests that demand extra > preparation or test input. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Renamed jdk_core_manual to jdk_core_manual_interactive - Changes: - all: https://git.openjdk.org/jdk/pull/12840/files - new: https://git.openjdk.org/jdk/pull/12840/files/32496d97..7d64305c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12840=02 - incr: https://webrevs.openjdk.org/?repo=jdk=12840=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12840.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/12840/head:pull/12840 PR: https://git.openjdk.org/jdk/pull/12840
Re: RFR: JDK-8295859 Update Manual Test Groups [v2]
On Tue, 11 Apr 2023 20:50:28 GMT, Mark Sheppard wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > test/jdk/TEST.groups line 643: > >> 641: sun/security/tools/jarsigner/compatibility/Compatibility.java >> 642: >> 643: jdk_core_manual_human = \ > > jdk_core_manual_requires_human_input gave a good indication of what is needed > with this test group ... maybe jdk_core_manual_interactive if we don't want > to use requires_human_input The name "jdk_core_manual_requires_human_input" may not be suitable because some tests in this group require environment preparation or root privilege. I prefer the name "jdk_core_manual_interactive". - PR Review Comment: https://git.openjdk.org/jdk/pull/12840#discussion_r1163371467
Re: RFR: JDK-8295859 Update Manual Test Groups [v2]
> The purpose of this task is to add the difference between -manual jdk_core > and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order > to streamline the manual test execution process, a new test group called > jdk_core_manual_human has been created for manual tests that demand extra > preparation or test input. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/12840/files - new: https://git.openjdk.org/jdk/pull/12840/files/361985ba..32496d97 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12840=01 - incr: https://webrevs.openjdk.org/?repo=jdk=12840=00-01 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12840.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/12840/head:pull/12840 PR: https://git.openjdk.org/jdk/pull/12840
RFR: JDK-8295859 Update Manual Test Groups
The purpose of this task is to add the difference between -manual jdk_core and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order to streamline the manual test execution process, a new test group called jdk_core_manual_human has been created for manual tests that demand extra preparation or test input. - Commit messages: - JDK-8295859 Update Manual Test Groups. Changes: https://git.openjdk.org/jdk/pull/12840/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12840=00 Issue: https://bugs.openjdk.org/browse/JDK-8295859 Stats: 24 lines in 1 file changed: 16 ins; 3 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/12840.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12840/head:pull/12840 PR: https://git.openjdk.org/jdk/pull/12840
Re: RFR: JDK-8295859: Update Manual Test Groups [v6]
> This task is created to update the manual test groups. Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'JDK-8295859' of gh:bwhuang-us/jdk into JDK-8295859 - Added missing manual tests from :jdk_core. - Removed performance tests from the jdk_core_manual group as they have been covered in the client-atr test groups - Merge master - Merge branch 'master' into JDK-8295859 - Updated Manual Test Groups - Moved Compatibility.java back to jdk_core_manual_no_input_security. - Removed unwanted backslash. - Added missing manual tests from :jdk_core. - Removed performance tests from the jdk_core_manual group as they have been covered in the client-atr test groups - ... and 1 more: https://git.openjdk.org/jdk/compare/4ce493f0...479c2eac - Changes: https://git.openjdk.org/jdk/pull/10864/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10864=05 Stats: 24 lines in 1 file changed: 16 ins; 3 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/10864.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10864/head:pull/10864 PR: https://git.openjdk.org/jdk/pull/10864
Withdrawn: JDK-8295859: Update Manual Test Groups
On Tue, 25 Oct 2022 23:10:53 GMT, Bill Huang wrote: > This task is created to update the manual test groups. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/10864
Integrated: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only
On Tue, 31 Jan 2023 22:35:21 GMT, Bill Huang wrote: > Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. This pull request has now been integrated. Changeset: 20579e48 Author:Bill Huang URL: https://git.openjdk.org/jdk/commit/20579e48cf598e890aa35c5518ec8d0594f45385 Stats: 41 lines in 3 files changed: 37 ins; 1 del; 3 mod 824: java/security/Policy/Root/Root.java fails when home directory is read-only Reviewed-by: rhalade - PR: https://git.openjdk.org/jdk/pull/12354
Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v5]
> Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Exclude Windows. - Changes: - all: https://git.openjdk.org/jdk/pull/12354/files - new: https://git.openjdk.org/jdk/pull/12354/files/49848a01..b8883211 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12354=04 - incr: https://webrevs.openjdk.org/?repo=jdk=12354=03-04 Stats: 15 lines in 1 file changed: 1 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/12354.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12354/head:pull/12354 PR: https://git.openjdk.org/jdk/pull/12354
Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v4]
> Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Check non-windows platform before retrieving user id. - Changes: - all: https://git.openjdk.org/jdk/pull/12354/files - new: https://git.openjdk.org/jdk/pull/12354/files/3b736036..49848a01 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12354=03 - incr: https://webrevs.openjdk.org/?repo=jdk=12354=02-03 Stats: 14 lines in 1 file changed: 3 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/12354.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12354/head:pull/12354 PR: https://git.openjdk.org/jdk/pull/12354
Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v3]
> Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Check root privilege with user id instead of user name. - Changes: - all: https://git.openjdk.org/jdk/pull/12354/files - new: https://git.openjdk.org/jdk/pull/12354/files/60096f09..3b736036 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12354=02 - incr: https://webrevs.openjdk.org/?repo=jdk=12354=01-02 Stats: 18 lines in 1 file changed: 14 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/12354.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12354/head:pull/12354 PR: https://git.openjdk.org/jdk/pull/12354
Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v2]
> Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/12354/files - new: https://git.openjdk.org/jdk/pull/12354/files/69a7a490..60096f09 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12354=01 - incr: https://webrevs.openjdk.org/?repo=jdk=12354=00-01 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/12354.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12354/head:pull/12354 PR: https://git.openjdk.org/jdk/pull/12354
RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only
Root.java is changed to a manual test because it requires test to be run with the root user privilege, and it requires to modify the user policy file in the home director. - Commit messages: - JDK-824 java/security/Policy/Root/Root.java fails when home directory is read-only Changes: https://git.openjdk.org/jdk/pull/12354/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12354=00 Issue: https://bugs.openjdk.org/browse/JDK-824 Stats: 18 lines in 3 files changed: 15 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/12354.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12354/head:pull/12354 PR: https://git.openjdk.org/jdk/pull/12354
Integrated: JDK-8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction
On Tue, 31 Jan 2023 19:08:08 GMT, Bill Huang wrote: > Test failed for exception in thread "main" java.lang.IllegalAccessError: > class IPv6NameserverPlatformParsingTest (in unnamed module @0x72a8ab1a) > cannot access class com.sun.jndi.dns.DnsContextFactory (in module > jdk.naming.dns) because module jdk.naming.dns does not export > com.sun.jndi.dns to unnamed module @0x72a8ab1a > at > IPv6NameserverPlatformParsingTest.main(IPv6NameserverPlatformParsingTest.java:46) > > This task is created to update test instruction to include --add-modules and > --add-opens jvm parameters to java command. This pull request has now been integrated. Changeset: 09bfbf80 Author:Bill Huang URL: https://git.openjdk.org/jdk/commit/09bfbf80639f059563fcd4432995b8c380cea298 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction Reviewed-by: alanb - PR: https://git.openjdk.org/jdk/pull/12351
Re: RFR: JDK-8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction [v2]
> Test failed for exception in thread "main" java.lang.IllegalAccessError: > class IPv6NameserverPlatformParsingTest (in unnamed module @0x72a8ab1a) > cannot access class com.sun.jndi.dns.DnsContextFactory (in module > jdk.naming.dns) because module jdk.naming.dns does not export > com.sun.jndi.dns to unnamed module @0x72a8ab1a > at > IPv6NameserverPlatformParsingTest.main(IPv6NameserverPlatformParsingTest.java:46) > > This task is created to update test instruction to include --add-modules and > --add-opens jvm parameters to java command. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Removed --add-modules. - Changes: - all: https://git.openjdk.org/jdk/pull/12351/files - new: https://git.openjdk.org/jdk/pull/12351/files/d274657f..d271f3ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12351=01 - incr: https://webrevs.openjdk.org/?repo=jdk=12351=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/12351.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12351/head:pull/12351 PR: https://git.openjdk.org/jdk/pull/12351
Re: RFR: JDK-8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction
On Tue, 31 Jan 2023 19:25:55 GMT, Alan Bateman wrote:
>> Test failed for exception in thread "main" java.lang.IllegalAccessError:
>> class IPv6NameserverPlatformParsingTest (in unnamed module @0x72a8ab1a)
>> cannot access class com.sun.jndi.dns.DnsContextFactory (in module
>> jdk.naming.dns) because module jdk.naming.dns does not export
>> com.sun.jndi.dns to unnamed module @0x72a8ab1a
>> at
>> IPv6NameserverPlatformParsingTest.main(IPv6NameserverPlatformParsingTest.java:46)
>>
>> This task is created to update test instruction to include --add-modules and
>> --add-opens jvm parameters to java command.
>
> test/jdk/com/sun/jndi/dns/Test6991580.java line 66:
>
>> 64: "3. Type \"cd " + System.getProperty("test.classes") + "\".",
>> 65: "4. Type \"" + System.getProperty("java.home") + "/bin/java"
>> 66: + " --add-modules java.desktop,jdk.naming.dns"
>
> I don't think you'll need the --add-modules in the instructions. The
> java.desktop exports as an API so it will be resolved by default, same for
> the java.naming and that will ensure that the JNDI service provider modules
> are resolved.
Thank you for the feedback. I will remove the --add-modules.
-
PR: https://git.openjdk.org/jdk/pull/12351
RFR: JDK-8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction
Test failed for exception in thread "main" java.lang.IllegalAccessError: class IPv6NameserverPlatformParsingTest (in unnamed module @0x72a8ab1a) cannot access class com.sun.jndi.dns.DnsContextFactory (in module jdk.naming.dns) because module jdk.naming.dns does not export com.sun.jndi.dns to unnamed module @0x72a8ab1a at IPv6NameserverPlatformParsingTest.main(IPv6NameserverPlatformParsingTest.java:46) This task is created to update test instruction to include --add-modules and --add-opens jvm parameters to java command. - Commit messages: - Update com/sun/jndi/dns/Test6991580.java manual test instruction Changes: https://git.openjdk.org/jdk/pull/12351/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12351=00 Issue: https://bugs.openjdk.org/browse/JDK-8300909 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/12351.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12351/head:pull/12351 PR: https://git.openjdk.org/jdk/pull/12351
Re: RFR: JDK-8295859: Update Manual Test Groups [v5]
> This task is created to update the manual test groups. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Added missing manual tests from :jdk_core. - Changes: - all: https://git.openjdk.org/jdk/pull/10864/files - new: https://git.openjdk.org/jdk/pull/10864/files/bd2b50a4..82974f1a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10864=04 - incr: https://webrevs.openjdk.org/?repo=jdk=10864=03-04 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10864.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10864/head:pull/10864 PR: https://git.openjdk.org/jdk/pull/10864
Re: RFR: JDK-8295859: Update Manual Test Groups [v4]
> This task is created to update the manual test groups. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Removed performance tests from the jdk_core_manual group as they have been covered in the client-atr test groups - Changes: - all: https://git.openjdk.org/jdk/pull/10864/files - new: https://git.openjdk.org/jdk/pull/10864/files/9006f137..bd2b50a4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10864=03 - incr: https://webrevs.openjdk.org/?repo=jdk=10864=02-03 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10864.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10864/head:pull/10864 PR: https://git.openjdk.org/jdk/pull/10864
Integrated: JDK-8295087: Manual Test to Automated Test Conversion
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote: > This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java This pull request has now been integrated. Changeset: a3693ccc Author:Bill Huang URL: https://git.openjdk.org/jdk/commit/a3693ccc617d06137a61050b34646e8a90ed3d7e Stats: 173 lines in 13 files changed: 71 ins; 32 del; 70 mod 8295087: Manual Test to Automated Test Conversion Reviewed-by: ssahoo, rhalade - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]
On Wed, 21 Dec 2022 20:39:03 GMT, Rajan Halade wrote: >> Multiple "run" in a single test fails the whole test when one test run fails >> and all subsequent test run get terminated. Multiple tests with only one >> "run" each allows all test run to be excused, and they can be run in >> parallel. > > I have not seen this used in any other tests. It is a good learning, I didn't > knew that multiple tests in single file are run in parallel. It seems like > good option. Do you know of any other regression test written this way? I didn't know that until Leonid posted this [comment](https://github.com/openjdk/jdk/pull/9813#discussion_r942908285) in one of my PRs. We do have a lot of tests written in this way and each test run will be given a unique id after the file name. For example, ExtDirs.java has two test run, and they will be named as ExtDirs.java#id0 and ExtDirs.java#id1. We can search "name:*.java#id*" in a Core Lib Mach5 run, it will show thousands of results. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]
On Wed, 21 Dec 2022 18:51:32 GMT, Rajan Halade wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33: > >> 31: >> 32: /* >> 33: * @test > > Why are these tags duplicated here? Multiple "run" in a single test fails the whole test when one test run fails and all subsequent test run get terminated. Multiple tests with only one "run" each allows all test run to be excused, and they can be run in parallel. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10637/files - new: https://git.openjdk.org/jdk/pull/10637/files/32b656ca..c6521f21 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10637=05 - incr: https://webrevs.openjdk.org/?repo=jdk=10637=04-05 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]
On Fri, 16 Dec 2022 12:06:14 GMT, Sibabrata Sahoo wrote: >> Bill Huang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8295087 >> - Added an extra line to the end of the policy file. >> - AssertThrows an exception in InconsistentEntries test. >> - Refactored to use testng framework for test enviroment setup. >> - Converted security manual tests to automated tests. > > test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 37: > >> 35: * @summary standard extensions path is hard-coded in default >> 36: * system policy file >> 37: * @run main/othervm/policy=ExtDirs.policy/secure=default ExtDirs > > May be "/secure=default" is optional here. Yes, you are right and we can remove the /secure. According to the JTReg spec. `If the /secure option is not used then the default security manager will be installed.` - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]
On Fri, 16 Dec 2022 11:48:54 GMT, Sibabrata Sahoo wrote:
>> Bill Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8295087
>> - Added an extra line to the end of the policy file.
>> - AssertThrows an exception in InconsistentEntries test.
>> - Refactored to use testng framework for test enviroment setup.
>> - Converted security manual tests to automated tests.
>
> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 52:
>
>> 50: private static final String JDK_HOME =
>> System.getProperty("test.jdk");
>> 51: private static final String TEST_SRC =
>> System.getProperty("test.src");
>> 52: private static final Path POLICY_DIR = Paths.get(JDK_HOME, "conf",
>> "security",
>
> This doesn't looks like a safe Test to be automated. Can it create conflict
> with any other existing Test requiring "testlimited" with
> default_local.policy? This need to be verified. Also changing anything inside
> an installed JDK probably not a good choice. It's just a thought from my side
> and it could be different for others.
Good points. I searched the entire repo and this is the only instance that uses
the "testlimited" with default_local.policy. Looking over the logic, the test
sets the crypto.policy property to "testlimited". So I am wondering if the
"testlimited" is created for test purposes. If so, are we allowed to rename
"testlimited" to be more specific, eg. "testcryptoperms"?
`Security.setProperty("crypto.policy", "testlimited");`
-
PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v8]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Reduced host input timeout to 5 minutes. - Changes: - all: https://git.openjdk.org/jdk/pull/10825/files - new: https://git.openjdk.org/jdk/pull/10825/files/c5648165..761cf908 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10825=07 - incr: https://webrevs.openjdk.org/?repo=jdk=10825=06-07 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295859: Update Manual Test Groups [v3]
> This task is created to add manual tests to the manual test groups. > > In addition, fix is provided for TestMatrix.java#Downcall-F and > TestMatrix.java#Downcall-T which are failing due to missing TestDowncall.java > ([JDK-8287158](https://bugs.openjdk.org/browse/JDK-8287158)). Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge master - Merge branch 'master' into JDK-8295859 - Updated Manual Test Groups - Changes: https://git.openjdk.org/jdk/pull/10864/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10864=02 Stats: 14 lines in 1 file changed: 13 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10864.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10864/head:pull/10864 PR: https://git.openjdk.org/jdk/pull/10864
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v7]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Reduced host input timeout to 20 minutes. - Changes: - all: https://git.openjdk.org/jdk/pull/10825/files - new: https://git.openjdk.org/jdk/pull/10825/files/3ae1f797..c5648165 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10825=06 - incr: https://webrevs.openjdk.org/?repo=jdk=10825=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into JDK-8295087 - Added an extra line to the end of the policy file. - AssertThrows an exception in InconsistentEntries test. - Refactored to use testng framework for test enviroment setup. - Converted security manual tests to automated tests. - Changes: - all: https://git.openjdk.org/jdk/pull/10637/files - new: https://git.openjdk.org/jdk/pull/10637/files/8b45f39f..32b656ca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10637=04 - incr: https://webrevs.openjdk.org/?repo=jdk=10637=03-04 Stats: 297635 lines in 3764 files changed: 148190 ins; 96710 del; 52735 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295859: Update Manual Test Groups [v2]
> This task is created to add manual tests to the manual test groups. > > In addition, fix is provided for TestMatrix.java#Downcall-F and > TestMatrix.java#Downcall-T which are failing due to missing TestDowncall.java > ([JDK-8287158](https://bugs.openjdk.org/browse/JDK-8287158)). Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8295859 - Updated Manual Test Groups - Changes: - all: https://git.openjdk.org/jdk/pull/10864/files - new: https://git.openjdk.org/jdk/pull/10864/files/ec9951c5..2c0bf381 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10864=01 - incr: https://webrevs.openjdk.org/?repo=jdk=10864=00-01 Stats: 151531 lines in 2242 files changed: 50384 ins; 83055 del; 18092 mod Patch: https://git.openjdk.org/jdk/pull/10864.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10864/head:pull/10864 PR: https://git.openjdk.org/jdk/pull/10864
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v6]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge master - Implemented review comments. - Implemented review comments. - Reverted exclusion of nonlocal registry tests. - Updated test instruction messages. - Updated TEST.groups - JDK-8295756 Improve NonLocalRegistry Manual Test Process - Changes: https://git.openjdk.org/jdk/pull/10825/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10825=05 Stats: 350 lines in 7 files changed: 256 ins; 58 del; 36 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v5]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10825/files - new: https://git.openjdk.org/jdk/pull/10825/files/278564b3..cff3773c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10825=04 - incr: https://webrevs.openjdk.org/?repo=jdk=10825=03-04 Stats: 9 lines in 3 files changed: 5 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]
On Mon, 28 Nov 2022 13:56:29 GMT, Alan Bateman wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java > line 167: > >> 165: >> Set.copyOf(Arrays.asList(InetAddress.getAllByName(myHostName))); >> 166: Set hostAddrs = >> 167: >> Set.copyOf(Arrays.asList(InetAddress.getAllByName(host))); > > Is there a reason to change this from Set.of? This is a workaround for duplicate elements detected by Set.of(). On my localhost, InetAddress.getAllByName(localhost returns duplicate IPv6 addresses with different scoped id which is not counted during comparison. This change shouldn't impact the goal of these tests which is to verify that registry modification request from client side is prohibited. - PR: https://git.openjdk.org/jdk/pull/10825
Integrated: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote: > There is no new changes in the open portion of JDK, but extracting common > functionalities in bootstrap Utils to test/lib/Utils which can be used in the > closed part. This pull request has now been integrated. Changeset: cc8bf950 Author:Bill Huang URL: https://git.openjdk.org/jdk/commit/cc8bf95046d1fba0f88b0e17481f36b2be870659 Stats: 473 lines in 4 files changed: 236 ins; 234 del; 3 mod 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils Reviewed-by: sspitsyn, kevinw - PR: https://git.openjdk.org/jdk/pull/11029
Re: RFR: JDK-8293450 Convert test/sun/management/ shell tests to Java version [v2]
On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang wrote: >> There is no new changes in the open portion of JDK, but extracting common >> functionalities in bootstrap Utils to test/lib/Utils which can be used in >> the closed part. > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Implemented review comments. It seems there is an integration issue with this PR as the JBS ticket is marked as confidential. I will open a new ticket for this change. - PR: https://git.openjdk.org/jdk/pull/11029
Re: RFR: JDK-8293450 Convert test/sun/management/ shell tests to Java version
On Tue, 8 Nov 2022 08:39:39 GMT, Serguei Spitsyn wrote: >> There is no new changes in the open portion of JDK, but extracting common >> functionalities in bootstrap Utils to test/lib/Utils which can be used in >> the closed part. > > test/lib/jdk/test/lib/Utils.java line 1007: > >> 1005: } >> 1006: } >> 1007: } > > What was your motivation to get rid of the `Util` methods `revokeAccess`, > `allowAccess` and `buildAclEntry`? The implementation did not become more > clearer nor simpler. But reviewing it became harder. Sure, I will add those methods back. - PR: https://git.openjdk.org/jdk/pull/11029
Re: RFR: JDK-8293450 Convert test/sun/management/ shell tests to Java version [v2]
> There is no new changes in the open portion of JDK, but extracting common > functionalities in bootstrap Utils to test/lib/Utils which can be used in the > closed part. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/11029/files - new: https://git.openjdk.org/jdk/pull/11029/files/98a7188e..191cd5ca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11029=01 - incr: https://webrevs.openjdk.org/?repo=jdk=11029=00-01 Stats: 47 lines in 1 file changed: 31 ins; 11 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/11029.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11029/head:pull/11029 PR: https://git.openjdk.org/jdk/pull/11029
Re: RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version
On Mon, 7 Nov 2022 23:20:15 GMT, Serguei Spitsyn wrote: >> There is no new changes in the open portion of JDK, but extracting common >> functionalities in bootstrap Utils to test/lib/Utils which can be used in >> the closed part. > > The refactoring looks pretty good. > But I have a couple of questions. > Q1: The method `grantAccess` is converted to the util method > `grantFileAccess` and it does not look the same. Could you, please, explain > what are the changes? > Q2: I'm confused about conversion of the shell tests. Your fix does not > convert any shell test. Also, I do not see any changes to the shell ile > `test/jdk/sun/management/jmxremote/bootstrap/ReadWriteForbidsCreateTest.sh` > listed in the enhancement. Can you explain, please? Hi @sspitsyn, the methods `grantAccess` and `grantFileAccess` are almost identical except for the parameter `AccessControl access` being changed to a boolean which is used to indicate user access or full access. There is also a minor change in building a new ACL entry out of the original entry. For your Q2 , it is in closed part of JDK. Please see the JBS ticket for the PR link. - PR: https://git.openjdk.org/jdk/pull/11029
RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version
There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils. - Commit messages: - JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version Changes: https://git.openjdk.org/jdk/pull/11029/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11029=00 Issue: https://bugs.openjdk.org/browse/JDK-8293450 Stats: 453 lines in 4 files changed: 216 ins; 234 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/11029.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11029/head:pull/11029 PR: https://git.openjdk.org/jdk/pull/11029
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]
On Fri, 4 Nov 2022 15:17:43 GMT, Mahendra Chhipa wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverted exclusion of nonlocal registry tests.
>
> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
> line 222:
>
>> 220: System.out.printf("Found expected AccessException: %s%n%n",
>> t);
>> 221: } else {
>> 222: throw new RuntimeException("AccessException did not occur
>> when expected", ex);
>
> private static void assertIsAccessException(Throwable ex) is define in all
> these three test classes, move this method in lib/jdk/test/lib
This method is test dependent that checks for specific keywords in the
AccessException. It seems better remain inside the test classes.
-
PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10825/files - new: https://git.openjdk.org/jdk/pull/10825/files/5ee556aa..278564b3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10825=03 - incr: https://webrevs.openjdk.org/?repo=jdk=10825=02-03 Stats: 217 lines in 5 files changed: 75 ins; 113 del; 29 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Reverted exclusion of nonlocal registry tests. - Changes: - all: https://git.openjdk.org/jdk/pull/10825/files - new: https://git.openjdk.org/jdk/pull/10825/files/a61d56e4..5ee556aa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10825=02 - incr: https://webrevs.openjdk.org/?repo=jdk=10825=01-02 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v2]
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer instruction to > the test engineer about the test requirement. > > Tests include: > java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java > java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java > javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Updated test instruction messages. - Changes: - all: https://git.openjdk.org/jdk/pull/10825/files - new: https://git.openjdk.org/jdk/pull/10825/files/a190fc71..a61d56e4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10825=01 - incr: https://webrevs.openjdk.org/?repo=jdk=10825=00-01 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295859: Update Manual Test Groups
On Wed, 26 Oct 2022 08:16:37 GMT, Alan Bateman wrote: >> This task is created to add manual tests to the manual test groups. >> >> In addition, fix is provided for TestMatrix.java#Downcall-F and >> TestMatrix.java#Downcall-T which are failing due to missing >> TestDowncall.java >> ([JDK-8287158](https://bugs.openjdk.org/browse/JDK-8287158)). > > No objection to this but it seems a maintenance burden and I'm curious why > these runs aren't run with the jtreg -manual option that will select the > manual tests, e.g. `-listtests -manual open/test/jdk/:jdk_core` will list the > tests in jdk_core that are configured to run /manual. Hi @AlanBateman, the manual group was created for ATR purposes because the manual tests are outsourced, it is easier to organize and analyze the results. Also, it is consolidated with manual tests in jdk_core, jdk_nio, jdk_foreign and other categories. - PR: https://git.openjdk.org/jdk/pull/10864
RFR: JDK-8295859: Update Manual Test Groups
This task is created to add manual tests to the manual test groups. In addition, fix is provided for TestMatrix.java#Downcall-F and TestMatrix.java#Downcall-T which are failing due to missing TestDowncall.java ([JDK-8287158](https://bugs.openjdk.org/browse/JDK-8287158)). - Commit messages: - Updated Manual Test Groups Changes: https://git.openjdk.org/jdk/pull/10864/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10864=00 Issue: https://bugs.openjdk.org/browse/JDK-8295859 Stats: 42 lines in 2 files changed: 35 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/10864.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10864/head:pull/10864 PR: https://git.openjdk.org/jdk/pull/10864
RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process
The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. Tests include: java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java - Commit messages: - Updated TEST.groups - JDK-8295756 Improve NonLocalRegistry Manual Test Process Changes: https://git.openjdk.org/jdk/pull/10825/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10825=00 Issue: https://bugs.openjdk.org/browse/JDK-8295756 Stats: 270 lines in 6 files changed: 235 ins; 2 del; 33 mod Patch: https://git.openjdk.org/jdk/pull/10825.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825 PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v4]
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Added an extra line to the end of the policy file. - Changes: - all: https://git.openjdk.org/jdk/pull/10637/files - new: https://git.openjdk.org/jdk/pull/10637/files/cfb9f74d..8b45f39f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10637=03 - incr: https://webrevs.openjdk.org/?repo=jdk=10637=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Tue, 18 Oct 2022 19:53:50 GMT, Mahendra Chhipa wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AssertThrows an exception in InconsistentEntries test. > > test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: > >> 2: permission javax.crypto.CryptoAllPermission; >> 3: permission javax.crypto.CryptoPermission "DES", 64; >> 4: } > > please remove extra line. I double-checked, there is no extra line at the end of this file. > test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line 46: > >> 44: * @summary standard extensions path is hard-coded in default >> 45: * system policy file >> 46: * > > No need to repeat these statement again. Are you saying that we don't need to run the ExtDir2.policy and ExtDir3.policy? - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: AssertThrows an exception in InconsistentEntries test. - Changes: - all: https://git.openjdk.org/jdk/pull/10637/files - new: https://git.openjdk.org/jdk/pull/10637/files/4911518e..cfb9f74d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10637=02 - incr: https://webrevs.openjdk.org/?repo=jdk=10637=01-02 Stats: 9 lines in 1 file changed: 1 ins; 6 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v2]
On Fri, 14 Oct 2022 15:50:30 GMT, Bill Huang wrote:
>> test/jdk/java/security/Policy/Root/Root.java line 48:
>>
>>> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy");
>>> 47: public static void main(String[] args) throws Exception {
>>> 48: Files.copy(SOURCE, TARGET, StandardCopyOption.REPLACE_EXISTING);
>>
>> Could you please use the testng framework for initial setup of test.
>
> This is a @driver test that copies the Root.policy file to the home directory
> before running the RootTest in a new JVM. The reason is that upon the start
> of the new JVM it loads the default system-wide policy file and the default
> user policy file which is the Root.policy we just copied. With the testng
> framework, there is no way to load the custom user policy file without
> reinstalling the security manager in the test, that said, it doesn't match
> what the manual test does.
Discussed with Mahendra offline, testng framework `@BeforeTest` performs test
setup in the client JVM before test starts in the other JVM. We can use testng
framework in this case to handle the policy file operations.
-
PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v2]
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Refactored to use testng framework for test enviroment setup. - Changes: - all: https://git.openjdk.org/jdk/pull/10637/files - new: https://git.openjdk.org/jdk/pull/10637/files/5a47cacd..4911518e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10637=01 - incr: https://webrevs.openjdk.org/?repo=jdk=10637=00-01 Stats: 83 lines in 2 files changed: 10 ins; 29 del; 44 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion
On Fri, 14 Oct 2022 11:00:44 GMT, Mahendra Chhipa wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java
>> javax/crypto/CryptoPermissions/InconsistentEntries.java
>
> test/jdk/java/security/Policy/Root/Root.java line 48:
>
>> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy");
>> 47: public static void main(String[] args) throws Exception {
>> 48: Files.copy(SOURCE, TARGET, StandardCopyOption.REPLACE_EXISTING);
>
> Could you please use the testng framework for initial setup of test.
This is a @driver test that copies the Root.policy file to the home directory
before running the RootTest in a new JVM. The reason is that upon the start of
the new JVM it loads the default system-wide policy file and the default user
policy file which is the Root.policy we just copied. With the testng framework,
there is no way to load the custom user policy file without reinstalling the
security manager in the test, that said, it doesn't match what the manual test
does.
> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 31:
>
>> 29: * @summary Test limited/default_local.policy containing inconsistent
>> entries
>> 30: * @library /test/lib
>> 31: * @run driver InconsistentEntries
>
> Use the testng framework.
Same reason as Root.java. The custom policy file needs to place in Java home
directory before running the test.
-
PR: https://git.openjdk.org/jdk/pull/10637
Integrated: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
On Mon, 10 Oct 2022 18:18:55 GMT, Bill Huang wrote: > The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification which originated from > [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663). This pull request has now been integrated. Changeset: ac194142 Author:Bill Huang Committer: Naoto Sato URL: https://git.openjdk.org/jdk/commit/ac1941425bdb1a25aa3364eef9eb1092ee716761 Stats: 497 lines in 3 files changed: 485 ins; 2 del; 10 mod 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance Reviewed-by: naoto - PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification which originated from > [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663). Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Fixed typo. - Changes: - all: https://git.openjdk.org/jdk/pull/10635/files - new: https://git.openjdk.org/jdk/pull/10635/files/b808c0a5..4c08a3e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10635=03 - incr: https://webrevs.openjdk.org/?repo=jdk=10635=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10635.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10635/head:pull/10635 PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v3]
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification which originated from > [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663). Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Added documentation to UIBuilder. - Changes: - all: https://git.openjdk.org/jdk/pull/10635/files - new: https://git.openjdk.org/jdk/pull/10635/files/a36cd005..b808c0a5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10635=02 - incr: https://webrevs.openjdk.org/?repo=jdk=10635=01-02 Stats: 267 lines in 3 files changed: 160 ins; 105 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10635.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10635/head:pull/10635 PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]
On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > I have a question, why must this test be manual? Can't we compare the > localized texts? Hi @wangweij, I have a discussion with @naotoj about automating this test. Here is a summary. 1. We can't hard code localized texts into the test and compare to the localized message form the tool. The main reason is mentioned above by @naotoj. Another reason is that localization sometimes may come in slightly different, correctness of translation is not the goal of this test. 2. We can't do a word-to-word comparison. But even so, we can't rely on the same resource bundle used by the tools for localization validation. It provokes a risk that test may fail to detect any localization error in the tool as they use the same mechanism. 3. It makes a bit more sense for this test being a manual test because it matches the look-and-feel criteria. With someone looking into the result, at least it can raise a flag if something doesn’t look right. And only engineers can do this. - PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v3]
On Tue, 11 Oct 2022 11:31:53 GMT, Mahendra Chhipa wrote: >> Added test cases for xpath Axis: >> 1. descendant >> 2. descendant-or-self >> 3. following >> 4. following-sibling > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Added predicate tests. Marked as reviewed by bhuang (Author). - PR: https://git.openjdk.org/jdk/pull/10557
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]
On Tue, 11 Oct 2022 17:03:47 GMT, Naoto Sato wrote: > I have a question, why must this test be manual? Can't we compare the > localized texts? @wangweij Good question. We can definitely compare the localized texts at least some keywords. The fact that automation is one of the goals of this task. In terms of localization, perhaps in our tests we can reuse the resource bundles implemented in these tools to turn english texts into localized texts. - PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification which originated from > [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663. Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10635/files - new: https://git.openjdk.org/jdk/pull/10635/files/7812f3c4..a36cd005 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10635=01 - incr: https://webrevs.openjdk.org/?repo=jdk=10635=00-01 Stats: 203 lines in 2 files changed: 113 ins; 78 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/10635.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10635/head:pull/10635 PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
On Mon, 10 Oct 2022 19:47:37 GMT, Naoto Sato wrote:
>> The jarsigner and keytool are localized into English, German, Japanese and
>> Simplified Chinese. This task is to modify the existing i18n tests to
>> validate i18n compliance in these tools.
>>
>> In addition, this task also contains changes for manual test enhancement and
>> simplification which originated from
>> [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663.
>
> test/jdk/sun/security/tools/keytool/i18n.java line 250:
>
>> 248: private Thread currentThread = null;
>> 249:
>> 250: public static class DialogBuilder {
>
> This seems to be a boilerplate for displaying the panel. Could this be
> separated from the test and converted into some library?
Sure, we can move this code to the library as there is no test code in it.
-
PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
On Mon, 10 Oct 2022 19:45:31 GMT, Naoto Sato wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains changes for manual test enhancement and >> simplification which originated from >> [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663. > > test/jdk/sun/security/tools/keytool/i18n.java line 62: > >> 60: * @library /test/lib >> 61: * @run main/manual/othervm i18n zh CN >> 62: */ > > Do you need to triplicate these `@test` tags? Would 3-lines of `@run` suffice? > Also setting the locale by `-Duser.language/country` and `getProperty` them > in the main would be preferable to passing them as the test case arguments. Sure, I can make a change to use the system property. Regarding your first question, a test with multiple 'run' fails and terminates on the first test failure. So I would prefer to have multiple tests rather than multiple 'run' in a single test that it allows jtreg to run all the tests independently. - PR: https://git.openjdk.org/jdk/pull/10635
RFR: JDK-8295087: Manual Test to Automated Test Conversion
This task converts 5 manual tests to automated tests. sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java sun/security/provider/PolicyParser/ExtDirsChange.java sun/security/provider/PolicyParser/ExtDirs.java java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java javax/crypto/CryptoPermissions/InconsistentEntries.java - Commit messages: - Converted security manual tests to automated tests. Changes: https://git.openjdk.org/jdk/pull/10637/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10637=00 Issue: https://bugs.openjdk.org/browse/JDK-8295087 Stats: 210 lines in 13 files changed: 100 ins; 37 del; 73 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
The jarsigner and keytool are localized into English, German, Japanese and Simplified Chinese. This task is to modify the existing i18n tests to validate i18n compliance in these tools. In addition, this task also contains changes for manual test enhancement and simplification which originated from [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663. - Commit messages: - Update keytool i18n test. Changes: https://git.openjdk.org/jdk/pull/10635/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10635=00 Issue: https://bugs.openjdk.org/browse/JDK-8294994 Stats: 407 lines in 2 files changed: 395 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/10635.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10635/head:pull/10635 PR: https://git.openjdk.org/jdk/pull/10635
Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
On Wed, 5 Oct 2022 18:09:53 GMT, Bill Huang wrote: >> Added test cases for xpath Axis: >> 1. descendant >> 2. descendant-or-self >> 3. following >> 4. following-sibling > > test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFollowingTest.java line 108: > >> 106: }; >> 107: } >> 108: > > It would be good to add a predicate test for following. e.g. > `//foo:Customer/*[not(following::*)]` > `//*[not(following::*) and not(preceding::*)]` > `//Street[following::Street and preceding::Street]` Also good for following-sibling. - PR: https://git.openjdk.org/jdk/pull/10557
Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote:
> Added test cases for xpath Axis:
> 1. descendant
> 2. descendant-or-self
> 3. following
> 4. following-sibling
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 59:
> 57: {"/Customers/Customer[@id='x1']/descendant::Address",
> "/Customers/Customer[@id='x1']/Address"},
> 58: {"/Customers/Customer[@id='x1']/descendant::*",
> "/Customers/Customer[@id='x1']//*"},
> 59: {"/Customers/foo:Customer/foo:Address/descendant::*",
> "/Customers/foo:Customer/foo:Address//*"},
It would be good to add a test case to address the grandchildren or
grand-grandchildren nodes from the context node. e.g.
`/Customers/descendant::Street`
`/Customers//Street`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 65:
> 63:
> {"/Customers/Customer[@id='x1']/descendant-or-self::Address",
> "/Customers/Customer[@id = 'x1']/Address"},
> 64: {"/Customers/Customer[@id='x1']/descendant-or-self::*",
> "/Customers/Customer[@id='x1'] | /Customers/Customer[@id = 'x1']//*"},
> 65:
> {"/Customers/foo:Customer/foo:Address/descendant-or-self::*",
> "/Customers/foo:Customer/foo:Address |
> /Customers/foo:Customer/foo:Address//*"}
In the spec, there is a special note saying, "the location path //para[1] does
not mean the same as the location path /descendant::para[1]". Based on this, it
would be good to add a position test case for descendant. e.g.
`/Customers/descendant::Street[2]`
`/Customers/descendant::Street[position()=2]`
`//Street[2]`
`(//Street)[2]`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 108:
> 106: };
> 107: }
> 108:
It would be good to have a predicate test with descendant. e.g.
`//*[not(descendant::*)]`
`//*[descendant::Street and ancestor::Customer]`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFollowingTest.java line 56:
> 54: {"/Customers/Customer[@id='x1']/following::Address",
> "/Customers/Customer[@id != 'x1']/Address"},
> 55: {"/Customers/Customer[@id='x1']/following::*",
> "/Customers/Customer[@id != 'x1']/descendant-or-self::* |
> /Customers/foo:Customer/descendant-or-self::*"},
> 56: {"/Customers/foo:Customer/foo:Address/following::*",
> "/Customers/foo:Customer/foo:Age | /Customers/foo:Customer/foo:ClubMember"},
It would be good to access the grandchildren or grand-grandchildren following
nodes. e.g.
`//Customer/following::Street`
`//following::Street`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFollowingTest.java line 64:
> 62: {"/Customers/Customer[@id='x1']/following-sibling::*",
> "/Customers/Customer[@id != 'x1'] | /Customers/foo:Customer"},
> 63:
> {"/Customers/foo:Customer/foo:Address/following-sibling::*",
> "/Customers/foo:Customer/foo:Age | /Customers/foo:Customer/foo:ClubMember"}
> 64: };
It would be good to add a position test. e.g.
`//Customer/following::Street[2]`
`//following::Street[2]`
`//Customer/following-sibling::Customer[2]`
`//following-sibling::Customer[2]`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFollowingTest.java line 108:
> 106: };
> 107: }
> 108:
It would be good to add a predicate test for following. e.g.
`//foo:Customer/*[not(following::*)]`
`//*[not(following::*) and not(preceding::*)]`
`//Street[following::Street and preceding::Street]`
-
PR: https://git.openjdk.org/jdk/pull/10557
Integrated: JDK-8292990 Improve test coverage for XPath Axes: parent
On Wed, 31 Aug 2022 20:16:33 GMT, Bill Huang wrote: > The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes This pull request has now been integrated. Changeset: e3939737 Author:Bill Huang Committer: Joe Wang URL: https://git.openjdk.org/jdk/commit/e393973761eec8fe08d901d93fc5a9261b6faf14 Stats: 165 lines in 2 files changed: 165 ins; 0 del; 0 mod 8292990: Improve test coverage for XPath Axes: parent Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/10107
Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent [v3]
> The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Fixed typos. - Changes: - all: https://git.openjdk.org/jdk/pull/10107/files - new: https://git.openjdk.org/jdk/pull/10107/files/637b5899..656067f1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10107=02 - incr: https://webrevs.openjdk.org/?repo=jdk=10107=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10107.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10107/head:pull/10107 PR: https://git.openjdk.org/jdk/pull/10107
Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent [v2]
> The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10107/files - new: https://git.openjdk.org/jdk/pull/10107/files/887bc08f..637b5899 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10107=01 - incr: https://webrevs.openjdk.org/?repo=jdk=10107=00-01 Stats: 17 lines in 1 file changed: 5 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/10107.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10107/head:pull/10107 PR: https://git.openjdk.org/jdk/pull/10107
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v4]
On Thu, 1 Sep 2022 11:38:09 GMT, Mahendra Chhipa wrote: >> Added tests for namespace Axis. Tests incluse namspace expressions, >> namespace node counts and namespace node scope. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. Marked as reviewed by bwhuang...@github.com (no known OpenJDK username). - PR: https://git.openjdk.org/jdk/pull/9906
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v3]
On Wed, 31 Aug 2022 21:17:22 GMT, Mahendra Chhipa wrote: >> Added tests for namespace Axis. Tests incluse namspace expressions, >> namespace node counts and namespace node scope. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Added defaukt namsespace expressions. Changes requested by bwhuang...@github.com (no known OpenJDK username). - PR: https://git.openjdk.org/jdk/pull/9906
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v2]
On Thu, 25 Aug 2022 16:58:29 GMT, Mahendra Chhipa wrote:
>> Added tests for namespace Axis. Tests incluse namspace expressions,
>> namespace node counts and namespace node scope.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpNamespaceTest.java line 114:
> 112: {"//Customer/Name/namespace::dog", "dog", "xmlns",
> "xmlns:dog","www.pets.com"},
> 113: {"/Customers/Customer/Name/namespace::dog", "dog",
> "xmlns", "xmlns:dog","www.pets.com"}
> 114: };
It would good to test an element with a prefix. For example,
`{"//www.foo.com:Customer/namespace::foo", "foo", "xmlns", "xmlns:foo",
"www.foo.com"}`
I am not sure if the above expression is a practical use case. We may want to
use a more real-world expression.
`"/Customers/*[name()='foo:Customer']/namespace::foo"`
Some other expressions as follows,
`"/Customers/*[namespace-uri()='www.foo.com']/namespace::foo"`
`"/Customers/*[contains(name(.), 'foo:')]/namespace::foo"`
`"/Customers/*[starts-with(name(.), 'foo:')]/namespace::foo"`
`"//*[local-name()='Customer' and
namespace-uri()='www.foo.com']/namespace::foo"`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpNamespaceTest.java line 131:
> 129: {"//VendCustomer/Address/namespace::street"},
> 130: {"/Customers/VendCustomer/Address/namespace::street"}
> 131: };
It would be good to test empty namespace nodes on attribute nodes. For example,
`"//@id/namespace::*"`
`"//@*[name()='foo:id']/namespace::*"`
`"//@*[local-name()='id' and namespace-uri()='www.foo.com']/namespace::*"`
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpNamespaceTest.java line 164:
> 162:
> {"namespace-uri(/Customers/Customer/www.pets.com:Address)","www.pets.com" },
> 163: {"namespace-uri(/Customers/VendCustomer/Email)","" }
> 164: };
It would be good to test namespace-uri() on attributes. For example,
`{"namespace-uri(//@*[name()='id'])", ""}`
`{"namespace-uri(//@*[name()='foo:id'])", "www.foo.com"}`
-
PR: https://git.openjdk.org/jdk/pull/9906
RFR: JDK-8292990 Improve test coverage for XPath Axes: parent
The goal of this task is validating the parent axis contains the parent of the context node. Context nodes include - root node - element nodes - text nodes - attribute nodes - namespace nodes - comment nodes - Commit messages: - Add document root tests - Added relative parent tests. - Initial commit. Changes: https://git.openjdk.org/jdk/pull/10107/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10107=00 Issue: https://bugs.openjdk.org/browse/JDK-8292990 Stats: 160 lines in 2 files changed: 160 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10107.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10107/head:pull/10107 PR: https://git.openjdk.org/jdk/pull/10107
Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent
On Wed, 31 Aug 2022 20:16:33 GMT, Bill Huang wrote: > The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes @JoeWang-Java Hi Joe, could you please review this PR? - PR: https://git.openjdk.org/jdk/pull/10107
Integrated: JDK-8289949 Improve test coverage for XPath: operators
On Fri, 26 Aug 2022 16:48:03 GMT, Bill Huang wrote: > Provided coverage for XPath operators. Operators include: > * Boolean operators: or, and, =, !=, <, <=, >, >= > * Number operators: +, -, *, div, mod > * Union operator: | This pull request has now been integrated. Changeset: f6b63601 Author:Bill Huang Committer: Joe Wang URL: https://git.openjdk.org/jdk/commit/f6b636015573f9b88133efba2f87bed80f463a96 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod 8289949: Improve test coverage for XPath: operators Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/10047
Re: RFR: JDK-8289949 Improve test coverage for XPath: operators [v2]
> Provided coverage for XPath operators. Operators include: > * Boolean operators: or, and, =, !=, <, <=, >, >= > * Number operators: +, -, *, div, mod > * Union operator: | Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10047/files - new: https://git.openjdk.org/jdk/pull/10047/files/f593e71d..fb252477 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=10047=01 - incr: https://webrevs.openjdk.org/?repo=jdk=10047=00-01 Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/10047.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10047/head:pull/10047 PR: https://git.openjdk.org/jdk/pull/10047
RFR: JDK-8289949 Improve test coverage for XPath: operators
Provided coverage for XPath operators. Operators include: * Boolean operators: or, and, =, !=, <, <=, >, >= * Number operators: +, -, *, div, mod * Union operator: | - Commit messages: - Created XPathOperatorExpTest.java Changes: https://git.openjdk.org/jdk/pull/10047/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10047=00 Issue: https://bugs.openjdk.org/browse/JDK-8289949 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10047.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10047/head:pull/10047 PR: https://git.openjdk.org/jdk/pull/10047
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v2]
On Thu, 25 Aug 2022 16:58:29 GMT, Mahendra Chhipa wrote: >> Added tests for namespace Axis. Tests incluse namspace expressions, >> namespace node counts and namespace node scope. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. One last thing I'd like to add is the default namespace, notated as xmlns="". Since this will impact most of the existing test cases, I am fine with adding it to one of the grandchildren and testing from there. - PR: https://git.openjdk.org/jdk/pull/9906
RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
This task converts 2 shell tests to java version. test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh test/java/lang/management/RuntimeMXBean/TestInputArgument.sh - Commit messages: - Updated copyright header. - Converted TestInputArgument.sh to java version. - Coverted TestSystemLoadAvg shell test to java version. Changes: https://git.openjdk.org/jdk/pull/9848/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9848=00 Issue: https://bugs.openjdk.org/browse/JDK-8292066 Stats: 200 lines in 4 files changed: 43 ins; 144 del; 13 mod Patch: https://git.openjdk.org/jdk/pull/9848.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9848/head:pull/9848 PR: https://git.openjdk.org/jdk/pull/9848
Integrated: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote: > This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh > test/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > test/java/lang/management/MemoryMXBean/PendingAllGC.sh This pull request has now been integrated. Changeset: 7ea9ba1f Author:Bill Huang Committer: Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea Stats: 346 lines in 9 files changed: 37 ins; 303 del; 6 mod 8292064: Convert java/lang/management/MemoryMXBean shell tests to java version Reviewed-by: lmesnik, sspitsyn - PR: https://git.openjdk.org/jdk/pull/9813
Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version [v3]
> This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh > test/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > test/java/lang/management/MemoryMXBean/PendingAllGC.sh Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Removed @build and move runs to separate tests. - Changes: - all: https://git.openjdk.org/jdk/pull/9813/files - new: https://git.openjdk.org/jdk/pull/9813/files/75e7f722..b363daa3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=9813=02 - incr: https://webrevs.openjdk.org/?repo=jdk=9813=01-02 Stats: 25 lines in 2 files changed: 22 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/9813.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9813/head:pull/9813 PR: https://git.openjdk.org/jdk/pull/9813
Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version [v2]
On Wed, 10 Aug 2022 21:09:42 GMT, Leonid Mesnik wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed GC settings. > > test/jdk/java/lang/management/MemoryMXBean/MemoryManagement.java line 35: > >> 33: * @modules jdk.management >> 34: * @build MemoryManagement MemoryUtil >> 35: * @run main/othervm/timeout=600 -Xmn8m -XX:+IgnoreUnrecognizedVMOptions > > Do we want to run this configuration without G1? Might be separate runs and > add requires? It doesn't fail with other GC modes, but I agree that it is misleading. We can make it a separate test and add @requires. - PR: https://git.openjdk.org/jdk/pull/9813
Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version [v2]
> This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh > test/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > test/java/lang/management/MemoryMXBean/PendingAllGC.sh Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Removed GC settings. - Changes: - all: https://git.openjdk.org/jdk/pull/9813/files - new: https://git.openjdk.org/jdk/pull/9813/files/2fa6e2f8..75e7f722 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=9813=01 - incr: https://webrevs.openjdk.org/?repo=jdk=9813=00-01 Stats: 33 lines in 4 files changed: 0 ins; 31 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/9813.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9813/head:pull/9813 PR: https://git.openjdk.org/jdk/pull/9813
Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote: > This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh > test/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > test/java/lang/management/MemoryMXBean/PendingAllGC.sh It sounds good to me as long as we don't lose coverage. I will update the scripts. - PR: https://git.openjdk.org/jdk/pull/9813
Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote: > This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh > test/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > test/java/lang/management/MemoryMXBean/PendingAllGC.sh It should be okay to remove the GC settings for these tests. I am just wondering how it would impact the test coverage in ATR. Let me bring this up to the SQE team. - PR: https://git.openjdk.org/jdk/pull/9813
RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version
This task converts 5 shell tests below to java version. test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh test/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh test/java/lang/management/MemoryMXBean/PendingAllGC.sh - Commit messages: - Removed othervm option in Pending.java. - Converted MemoryMXBean shell tests to java version. Changes: https://git.openjdk.org/jdk/pull/9813/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9813=00 Issue: https://bugs.openjdk.org/browse/JDK-8292064 Stats: 356 lines in 9 files changed: 48 ins; 303 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/9813.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9813/head:pull/9813 PR: https://git.openjdk.org/jdk/pull/9813
Integrated: JDK-8290836 Improve test coverage for XPath functions: String Functions
On Thu, 4 Aug 2022 17:40:43 GMT, Bill Huang wrote: > Improve test coverage for XPath functions: > [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836), > [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837), > [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838). This pull request has now been integrated. Changeset: d889264c Author: Bill Huang Committer: Joe Wang URL: https://git.openjdk.org/jdk/commit/d889264c6123b6c28bdd6336f5ae547e4e441aa7 Stats: 821 lines in 5 files changed: 806 ins; 3 del; 12 mod 8290836: Improve test coverage for XPath functions: String Functions 8290837: Improve test coverage for XPath functions: Boolean Functions 8290838: Improve test coverage for XPath functions: Number Functions Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/9752
Re: RFR: JDK-8290836 Improve test coverage for XPath functions: String Functions [v2]
> Improve test coverage for XPath functions: > [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836), > [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837), > [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838). Bill Huang has updated the pull request incrementally with one additional commit since the last revision: Added comments and fixed typo. - Changes: - all: https://git.openjdk.org/jdk/pull/9752/files - new: https://git.openjdk.org/jdk/pull/9752/files/5ab30e1b..9bdb1677 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=9752=01 - incr: https://webrevs.openjdk.org/?repo=jdk=9752=00-01 Stats: 137 lines in 5 files changed: 46 ins; 15 del; 76 mod Patch: https://git.openjdk.org/jdk/pull/9752.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9752/head:pull/9752 PR: https://git.openjdk.org/jdk/pull/9752
RFR: JDK-8290836 Improve test coverage for XPath functions: String Functions
Improve test coverage for XPath functions: [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836), [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837), [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838). - Commit messages: - Added exception test cases for node set functions. - Added exception tests. - Extracted common test codes for xpath exp eval to a new function. - Changes for String, Bollean and Number Functions Changes: https://git.openjdk.org/jdk/pull/9752/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9752=00 Issue: https://bugs.openjdk.org/browse/JDK-8290836 Stats: 790 lines in 5 files changed: 775 ins; 3 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/9752.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9752/head:pull/9752 PR: https://git.openjdk.org/jdk/pull/9752
Integrated: JDK-8289948: Improve test coverage for XPath functions: Node Set Functions
On Mon, 25 Jul 2022 22:04:31 GMT, Bill Huang wrote: > Provided coverage for XPath node set functions. Functions include: > - id() > - last() > - position() > - count() > - local-name() > - namespace-uri() > - name() This pull request has now been integrated. Changeset: 57bf603b Author:Bill Huang Committer: Joe Wang URL: https://git.openjdk.org/jdk/commit/57bf603b7332db86c39680d16b78f94a904daf46 Stats: 354 lines in 4 files changed: 309 ins; 10 del; 35 mod 8289948: Improve test coverage for XPath functions: Node Set Functions Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/9633
Integrated: 8289511: Improve test coverage for XPath Axes: child
On Wed, 13 Jul 2022 21:04:11 GMT, Bill Huang wrote: > This is a subtask of > [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming to > improve XPath expression test coverage. The goal of this subtask is > validating the XPath child axis specifier in various ways. This pull request has now been integrated. Changeset: cfe9026f Author: Bill Huang Committer: Joe Wang URL: https://git.openjdk.org/jdk/commit/cfe9026fe0506488cc0f0557299cfa585811d194 Stats: 237 lines in 1 file changed: 237 ins; 0 del; 0 mod 8289511: Improve test coverage for XPath Axes: child Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/9484
